extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-09 12:35:59 +02:00
Code Issues Packages Projects Releases Wiki Activity

Plugin explicit flags (#11581)

Browse Source 
# Description
#11492 fixed flags for builtin commands but I missed that plugins don't
use the same `has_flag` that builtins do. This PR addresses this.

Unfortunately this means that return value of `has_flag` needs to change
from `bool` to `Result<bool, ShellError>` to produce an error when
explicit value is not a boolean (just like in case of `has_flag` for
builtin commands. It is not possible to check this in
`EvaluatedCall::try_from_call` because

# User-Facing Changes
Passing explicit values to flags of plugin commands (like `--flag=true`
`--flag=false`) should work now.
BREAKING: changed return value of `EvaluatedCall::has_flag` method from
`bool` to `Result<bool, ShellError>`

# Tests + Formatting
Added tests and updated documentation and examples
This commit is contained in:
Artemiy
2024-01-23 00:00:43 +03:00
committed by GitHub
parent 415ebf207f
commit 092d496ff5
5 changed files with 86 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
crates/nu_plugin_inc/src/nu/mod.rs
View File

@ -40,13 +40,13 @@ impl Plugin for Inc {
self.cell_path = cell_path;
if call.has_flag("major") {
if call.has_flag("major")? {
self.for_semver(SemVerAction::Major);
}
if call.has_flag("minor") {
if call.has_flag("minor")? {
self.for_semver(SemVerAction::Minor);
}
if call.has_flag("patch") {
if call.has_flag("patch")? {
self.for_semver(SemVerAction::Patch);
}