extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-09 14:15:53 +02:00
Code Issues Packages Projects Releases Wiki Activity

rename nushell's cp command to cp-old making coreutils the default cp (#10678)

Browse Source 
# Description

This PR renames nushell's `cp` command to `cp-old` to make room for
`ucp` to be renamed to `cp`, making the coreutils version of `cp` the
default for nushell. After some period of time, we should remove
`cp-old` entirely.

# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->

# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use std testing; testing run-tests --path
crates/nu-std"` to run the tests for the standard library

> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->

# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
This commit is contained in:
Darren Schroeder
2023-10-10 18:13:28 -05:00
committed by GitHub
parent c81fa397b6
commit 0ba81f1d51
6 changed files with 60 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

64
crates/nu-command/tests/commands/ucp.rs
View File

@ -33,7 +33,7 @@ fn copies_a_file_impl(progress: bool) {
nu!(
cwd: dirs.root(),
"ucp {} `{}` ucp_test_1/sample.ini",
"cp {} `{}` ucp_test_1/sample.ini",
progress_flag,
test_file.display()
);
@ -61,7 +61,7 @@ fn copies_the_file_inside_directory_if_path_to_copy_is_directory_impl(progress:
let first_hash = get_file_hash(dirs.formats().join("../formats/sample.ini").display());
nu!(
cwd: dirs.formats(),
"ucp {} ../formats/sample.ini {}",
"cp {} ../formats/sample.ini {}",
progress_flag,
expected_file.dir()
);
@ -86,7 +86,7 @@ fn error_if_attempting_to_copy_a_directory_to_another_directory_impl(progress: b
let progress_flag = if progress { "-p" } else { "" };
let actual = nu!(
cwd: dirs.formats(),
"ucp {} ../formats {}",
"cp {} ../formats {}",
progress_flag,
dirs.test().display()
);
@ -124,7 +124,7 @@ fn copies_the_directory_inside_directory_if_path_to_copy_is_directory_and_with_r
nu!(
cwd: dirs.test(),
"ucp {} originals expected -r",
"cp {} originals expected -r",
progress_flag
);
@ -174,7 +174,7 @@ fn deep_copies_with_recursive_flag_impl(progress: bool) {
nu!(
cwd: dirs.test(),
"ucp {} originals expected --recursive",
"cp {} originals expected --recursive",
progress_flag
);
@ -213,7 +213,7 @@ fn copies_using_path_with_wildcard_impl(progress: bool) {
nu!(
cwd: dirs.formats(),
"ucp {} -r ../formats/* {}",
"cp {} -r ../formats/* {}",
progress_flag,
dirs.test().display()
);
@ -258,7 +258,7 @@ fn copies_using_a_glob_impl(progress: bool) {
nu!(
cwd: dirs.formats(),
"ucp {} -r * {}",
"cp {} -r * {}",
progress_flag,
dirs.test().display()
);
@ -298,14 +298,14 @@ fn copies_same_file_twice_impl(progress: bool) {
nu!(
cwd: dirs.root(),
"ucp {} `{}` ucp_test_8/sample.ini",
"cp {} `{}` ucp_test_8/sample.ini",
progress_flag,
dirs.formats().join("sample.ini").display()
);
nu!(
cwd: dirs.root(),
"ucp {} `{}` ucp_test_8/sample.ini",
"cp {} `{}` ucp_test_8/sample.ini",
progress_flag,
dirs.formats().join("sample.ini").display()
);
@ -370,7 +370,7 @@ fn copy_file_and_dir_from_two_parents_up_using_multiple_dots_to_current_dir_recu
nu!(
cwd: dirs.test().join("foo/bar"),
"ucp {} -r .../hello* .",
"cp {} -r .../hello* .",
progress_flag
);
@ -394,7 +394,7 @@ fn copy_to_non_existing_dir_impl(progress: bool) {
let actual = nu!(
cwd: sandbox.cwd(),
"ucp {} empty_file ~/not_a_dir{}",
"cp {} empty_file ~/not_a_dir{}",
progress_flag,
PATH_SEPARATOR,
);
@ -512,7 +512,7 @@ fn copy_identical_file_impl(progress: bool) {
let actual = nu!(
cwd: dirs.test(),
"ucp {} same.txt same.txt",
"cp {} same.txt same.txt",
progress_flag,
);
// assert!(actual.err.contains("Copy aborted"));
@ -568,7 +568,7 @@ fn copy_file_not_exists_dst_impl(progress: bool) {
let actual = nu!(
cwd: sandbox.cwd(),
"ucp {} valid.txt ~/invalid_dir/invalid_dir1",
"cp {} valid.txt ~/invalid_dir/invalid_dir1",
progress_flag,
);
assert!(
@ -597,7 +597,7 @@ fn copy_file_with_read_permission_impl(progress: bool) {
let actual = nu!(
cwd: sandbox.cwd(),
"ucp {} valid.txt invalid_prem.txt",
"cp {} valid.txt invalid_prem.txt",
progress_flag,
);
assert!(actual.err.contains("invalid_prem.txt") && actual.err.contains("denied"));
@ -629,7 +629,7 @@ fn test_cp_cp() {
nu!(
cwd: dirs.root(),
"ucp {} ucp_test_19/{}",
"cp {} ucp_test_19/{}",
src.display(),
TEST_HELLO_WORLD_DEST
);
@ -654,7 +654,7 @@ fn test_cp_existing_target() {
// Copy existing file to destination, so that it exists for the test
nu!(
cwd: dirs.root(),
"ucp {} ucp_test_20/{}",
"cp {} ucp_test_20/{}",
existing.display(),
TEST_EXISTING_FILE
);
@ -665,7 +665,7 @@ fn test_cp_existing_target() {
// Now for the test
nu!(
cwd: dirs.root(),
"ucp {} ucp_test_20/{}",
"cp {} ucp_test_20/{}",
src.display(),
TEST_EXISTING_FILE
);
@ -694,7 +694,7 @@ fn test_cp_multiple_files() {
// Start test
nu!(
cwd: dirs.root(),
"ucp {} {} ucp_test_21/{}",
"cp {} {} ucp_test_21/{}",
src1.display(),
src2.display(),
TEST_COPY_TO_FOLDER
@ -727,7 +727,7 @@ fn test_cp_recurse() {
// Start test
nu!(
cwd: dirs.root(),
"ucp -r {} ucp_test_22/{}",
"cp -r {} ucp_test_22/{}",
TEST_COPY_FROM_FOLDER,
TEST_COPY_TO_FOLDER_NEW,
);
@ -747,7 +747,7 @@ fn test_cp_with_dirs() {
// Start test
nu!(
cwd: dirs.root(),
"ucp {} ucp_test_23/{}",
"cp {} ucp_test_23/{}",
src.display(),
TEST_COPY_TO_FOLDER,
);
@ -760,7 +760,7 @@ fn test_cp_with_dirs() {
let src2_hash = get_file_hash(src2.display());
nu!(
cwd: dirs.root(),
"ucp {} ucp_test_23/{}",
"cp {} ucp_test_23/{}",
src2.display(),
TEST_HELLO_WORLD_DEST,
);
@ -778,7 +778,7 @@ fn test_cp_arg_force() {
nu!(
cwd: dirs.root(),
"ucp {} --force ucp_test_24/{}",
"cp {} --force ucp_test_24/{}",
src.display(),
"invalid_prem.txt"
);
@ -794,7 +794,7 @@ fn test_cp_directory_to_itself_disallowed() {
sandbox.mkdir("d");
let actual = nu!(
cwd: dirs.root(),
"ucp -r ucp_test_25/{} ucp_test_25/{}",
"cp -r ucp_test_25/{} ucp_test_25/{}",
"d",
"d"
);
@ -812,7 +812,7 @@ fn test_cp_nested_directory_to_itself_disallowed() {
sandbox.mkdir("a/b/c");
let actual = nu!(
cwd: dirs.test(),
"ucp -r {} {}",
"cp -r {} {}",
"a/b",
"a/b/c"
);
@ -829,7 +829,7 @@ fn test_cp_same_file_force() {
sandbox.with_files(vec![EmptyFile("f")]);
let actual = nu!(
cwd: dirs.test(),
"ucp --force {} {}",
"cp --force {} {}",
"f",
"f"
);
@ -847,7 +847,7 @@ fn test_cp_arg_no_clobber() {
let actual = nu!(
cwd: dirs.root(),
"ucp {} {} --no-clobber",
"cp {} {} --no-clobber",
src.display(),
target.display()
);
@ -867,7 +867,7 @@ fn test_cp_arg_no_clobber_twice() {
]);
nu!(
cwd: dirs.root(),
"ucp --no-clobber ucp_test_29/{} ucp_test_29/{}",
"cp --no-clobber ucp_test_29/{} ucp_test_29/{}",
"source.txt",
"dest.txt"
);
@ -875,7 +875,7 @@ fn test_cp_arg_no_clobber_twice() {
nu!(
cwd: dirs.root(),
"ucp --no-clobber ucp_test_29/{} ucp_test_29/{}",
"cp --no-clobber ucp_test_29/{} ucp_test_29/{}",
"source_with_body.txt",
"dest.txt"
);
@ -891,7 +891,7 @@ fn test_cp_debug_default() {
let actual = nu!(
cwd: dirs.root(),
"ucp --debug {} ucp_test_30/{}",
"cp --debug {} ucp_test_30/{}",
src.display(),
TEST_HELLO_WORLD_DEST
);
@ -926,7 +926,7 @@ fn test_cp_verbose_default() {
let actual = nu!(
cwd: dirs.root(),
"ucp --verbose {} {}",
"cp --verbose {} {}",
src.display(),
TEST_HELLO_WORLD_DEST
);
@ -947,7 +947,7 @@ fn test_cp_only_source_no_dest() {
let src = dirs.fixtures.join("cp").join(TEST_HELLO_WORLD_SOURCE);
let actual = nu!(
cwd: dirs.root(),
"ucp {}",
"cp {}",
src.display(),
);
assert!(actual
@ -963,7 +963,7 @@ fn test_cp_with_vars() {
sandbox.with_files(vec![EmptyFile("input")]);
nu!(
cwd: dirs.test(),
"let src = 'input'; let dst = 'target'; ucp $src $dst",
"let src = 'input'; let dst = 'target'; cp $src $dst",
);
assert!(dirs.test().join("target").exists());
});