extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-19 00:56:01 +02:00
Code Issues Packages Projects Releases Wiki Activity

add dedicated const in pipeline, const builtin var errors (#7784)

Browse Source 
# Description

Currently `let` and `const` share error handling, and this might lead to
confusing error messages


![sJan17-51](https://user-images.githubusercontent.com/98623181/212981108-c80b3e55-cece-4ee5-ba8f-cb5dcfdf63e0.png)

This PR adds dedicated errors to `const`
This commit is contained in:
mike
2023-01-20 02:11:48 +03:00
committed by GitHub
parent 2982a2c963
commit 0fe2884397
3 changed files with 50 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
crates/nu-parser/src/parse_keywords.rs
View File

@@ -2842,8 +2842,11 @@ pub fn parse_let_or_const(
.to_string();
if ["in", "nu", "env", "nothing"].contains(&var_name.as_str()) {
error =
error.or(Some(ParseError::LetBuiltinVar(var_name, lvalue.span)));
error = if is_const {
error.or(Some(ParseError::ConstBuiltinVar(var_name, lvalue.span)))
} else {
error.or(Some(ParseError::LetBuiltinVar(var_name, lvalue.span)))
};
}
let var_id = lvalue.as_var();