extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-09 08:45:45 +02:00
Code Issues Packages Projects Releases Wiki Activity

update miette and switch to GenericErrors (#5222)

Browse Source
This commit is contained in:
Kat Marchán
2022-04-18 05:34:10 -07:00
committed by GitHub
parent cf65f77b02
commit 1314a87cb0
141 changed files with 1569 additions and 689 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
crates/nu-plugin/src/plugin/declaration.rs
View File

@ -63,10 +63,12 @@ impl Command for PluginDeclaration {
let mut child = plugin_cmd.spawn().map_err(|err| {
let decl = engine_state.get_decl(call.decl_id);
ShellError::SpannedLabeledError(
ShellError::GenericError(
format!("Unable to spawn plugin for {}", decl.name()),
format!("{}", err),
call.head,
Some(call.head),
None,
Vec::new(),
)
})?;
@ -94,10 +96,12 @@ impl Command for PluginDeclaration {
let response = self.encoding.decode_response(&mut buf_read).map_err(|err| {
let decl = engine_state.get_decl(call.decl_id);
ShellError::SpannedLabeledError(
ShellError::GenericError(
format!("Unable to decode call for {}", decl.name()),
err.to_string(),
call.head,
Some(call.head),
None,
Vec::new(),
)
});
@ -106,18 +110,22 @@ impl Command for PluginDeclaration {
Ok(PipelineData::Value(value.as_ref().clone(), None))
}
Ok(PluginResponse::Error(err)) => Err(err.into()),
Ok(PluginResponse::Signature(..)) => Err(ShellError::SpannedLabeledError(
Ok(PluginResponse::Signature(..)) => Err(ShellError::GenericError(
"Plugin missing value".into(),
"Received a signature from plugin instead of value".into(),
call.head,
Some(call.head),
None,
Vec::new(),
)),
Err(err) => Err(err),
}
} else {
Err(ShellError::SpannedLabeledError(
Err(ShellError::GenericError(
"Error with stdout reader".into(),
"no stdout reader".into(),
call.head,
Some(call.head),
None,
Vec::new(),
))
};