extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-06-30 22:50:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix some nightly clippy warnings (#329)

Browse Source
This commit is contained in:
JT
2021-11-13 13:42:13 +13:00
committed by GitHub
parent db2bca56c9
commit 14a2918bba
5 changed files with 12 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
crates/nu-command/src/math/reducers.rs
View File

@ -98,11 +98,7 @@ pub fn sum(data: Vec<Value>, head: Span) -> Result<Value, ShellError> {
| Value::Float { .. }
| Value::Filesize { .. }
| Value::Duration { .. } => {
let new_value = acc.add(head, value);
if new_value.is_err() {
return new_value;
}
acc = new_value.expect("This should never trigger")
acc = acc.add(head, value)?;
}
other => {
return Err(ShellError::UnsupportedInput(
@ -133,11 +129,7 @@ pub fn product(data: Vec<Value>, head: Span) -> Result<Value, ShellError> {
for value in &data {
match value {
Value::Int { .. } | Value::Float { .. } => {
let new_value = acc.mul(head, value);
if new_value.is_err() {
return new_value;
}
acc = new_value.expect("This should never trigger")
acc = acc.mul(head, value)?;
}
other => {
return Err(ShellError::UnsupportedInput(

11
crates/nu-engine/src/documentation.rs
View File

@ -4,6 +4,7 @@ use std::collections::HashMap;
const COMMANDS_DOCS_DIR: &str = "docs/commands";
#[derive(Default)]
pub struct DocumentationConfig {
no_subcommands: bool,
//FIXME: add back in color support
@ -12,16 +13,6 @@ pub struct DocumentationConfig {
brief: bool,
}
impl Default for DocumentationConfig {
fn default() -> Self {
DocumentationConfig {
no_subcommands: false,
no_color: false,
brief: false,
}
}
}
fn generate_doc(name: &str, engine_state: &EngineState) -> (Vec<String>, Vec<Value>) {
let mut cols = vec![];
let mut vals = vec![];

2
crates/nu-parser/src/lib.rs
View File

@ -13,7 +13,7 @@ pub use lite_parse::{lite_parse, LiteBlock};
pub use parse_keywords::{
parse_alias, parse_def, parse_def_predecl, parse_let, parse_module, parse_use,
};
pub use parser::{find_captures_in_expr, parse, Import, VarDecl};
pub use parser::{find_captures_in_expr, parse, Import};
#[cfg(feature = "plugin")]
pub use parse_keywords::parse_plugin;

14
crates/nu-parser/src/parser.rs
View File

@ -24,12 +24,6 @@ use crate::parse_keywords::parse_plugin;
#[derive(Debug, Clone)]
pub enum Import {}
#[derive(Debug, Clone)]
pub struct VarDecl {
var_id: VarId,
expression: Expression,
}
pub fn garbage(span: Span) -> Expression {
Expression::garbage(span)
}
@ -271,7 +265,7 @@ fn parse_short_flags(
error = error.or_else(|| {
Some(ParseError::UnknownFlag(
sig.name.clone(),
format!("-{}", String::from_utf8_lossy(contents).to_string()),
format!("-{}", String::from_utf8_lossy(contents)),
*first,
))
});
@ -281,7 +275,7 @@ fn parse_short_flags(
error = error.or_else(|| {
Some(ParseError::UnknownFlag(
sig.name.clone(),
format!("-{}", String::from_utf8_lossy(contents).to_string()),
format!("-{}", String::from_utf8_lossy(contents)),
*first,
))
});
@ -291,7 +285,7 @@ fn parse_short_flags(
error = error.or_else(|| {
Some(ParseError::UnknownFlag(
sig.name.clone(),
format!("-{}", String::from_utf8_lossy(contents).to_string()),
format!("-{}", String::from_utf8_lossy(contents)),
*first,
))
});
@ -302,7 +296,7 @@ fn parse_short_flags(
error = error.or_else(|| {
Some(ParseError::UnknownFlag(
sig.name.clone(),
format!("-{}", String::from_utf8_lossy(contents).to_string()),
format!("-{}", String::from_utf8_lossy(contents)),
*first,
))
});