extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-09 16:35:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

Make FromValue take owned Values (#10900)

Browse Source 
# Description
Changes `FromValue` to take owned `Value`s instead of borrowed `Value`s.
This eliminates some unnecessary clones (e.g., in `call_ext.rs`).

# User-Facing Changes
Breaking API change for `nu_protocol`.
This commit is contained in:
Ian Manske
2023-10-31 18:47:00 +00:00
committed by GitHub
parent 1c52b112c8
commit 15c22db8f4
9 changed files with 102 additions and 116 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
crates/nu-engine/src/call_ext.rs
View File

@ -71,7 +71,7 @@ impl CallExt for Call {
) -> Result<Option<T>, ShellError> {
if let Some(expr) = self.get_flag_expr(name) {
let result = eval_expression(engine_state, stack, &expr)?;
FromValue::from_value(&result).map(Some)
FromValue::from_value(result).map(Some)
} else {
Ok(None)
}
@ -84,7 +84,7 @@ impl CallExt for Call {
) -> Result<Option<T>, ShellError> {
if let Some(expr) = self.get_flag_expr(name) {
let result = eval_constant(working_set, &expr)?;
FromValue::from_value(&result).map(Some)
FromValue::from_value(result).map(Some)
} else {
Ok(None)
}
@ -100,7 +100,7 @@ impl CallExt for Call {
for expr in self.positional_iter().skip(starting_pos) {
let result = eval_expression(engine_state, stack, expr)?;
output.push(FromValue::from_value(&result)?);
output.push(FromValue::from_value(result)?);
}
Ok(output)
@ -115,7 +115,7 @@ impl CallExt for Call {
for expr in self.positional_iter().skip(starting_pos) {
let result = eval_constant(working_set, expr)?;
output.push(FromValue::from_value(&result)?);
output.push(FromValue::from_value(result)?);
}
Ok(output)
@ -129,7 +129,7 @@ impl CallExt for Call {
) -> Result<Option<T>, ShellError> {
if let Some(expr) = self.positional_nth(pos) {
let result = eval_expression(engine_state, stack, expr)?;
FromValue::from_value(&result).map(Some)
FromValue::from_value(result).map(Some)
} else {
Ok(None)
}
@ -143,7 +143,7 @@ impl CallExt for Call {
) -> Result<T, ShellError> {
if let Some(expr) = self.positional_nth(pos) {
let result = eval_expression(engine_state, stack, expr)?;
FromValue::from_value(&result)
FromValue::from_value(result)
} else if self.positional_len() == 0 {
Err(ShellError::AccessEmptyContent { span: self.head })
} else {
@ -161,7 +161,7 @@ impl CallExt for Call {
) -> Result<T, ShellError> {
if let Some(expr) = self.positional_nth(pos) {
let result = eval_constant(working_set, expr)?;
FromValue::from_value(&result)
FromValue::from_value(result)
} else if self.positional_len() == 0 {
Err(ShellError::AccessEmptyContent { span: self.head })
} else {
@ -180,7 +180,7 @@ impl CallExt for Call {
) -> Result<T, ShellError> {
if let Some(expr) = self.get_parser_info(name) {
let result = eval_expression(engine_state, stack, expr)?;
FromValue::from_value(&result)
FromValue::from_value(result)
} else if self.parser_info.is_empty() {
Err(ShellError::AccessEmptyContent { span: self.head })
} else {