extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-02-16 10:32:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix some of the tests in tests::shell (#12417)

Browse Source 
# Description
Some of the tests in `tests::shell` were using `sh` unnecessarily, and
had `#[cfg(not(windows))]` when they should be testable on Windows if
`sh` is not used.

I also found that they were using `.expect()` incorrectly, under the
assumption that that would check their output, when really an
`assert_eq!` on the output is needed to do that. So these tests weren't
even really working properly before.

# User-Facing Changes
None

# Tests + Formatting
- 🟢 `toolkit fmt`
- 🟢 `toolkit clippy`
- 🟢 `toolkit test`
- 🟢 `toolkit test stdlib`
This commit is contained in:
Devyn Cairns 2024-04-05 20:57:47 -07:00 committed by GitHub
parent 0e36c43c64
commit 16cbed7d6e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 16 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
tests/shell/mod.rs
View File

@ -229,62 +229,46 @@ fn run_export_extern() {
} }
#[test] #[test]
#[cfg(not(windows))]
fn run_in_login_mode() { fn run_in_login_mode() {
let child_output = std::process::Command::new("sh") let child_output = std::process::Command::new(nu_test_support::fs::executable_path())
.arg("-c") .args(["-n", "-l", "-c", "echo $nu.is-login"])
.arg(format!(
"{:?} --no-config-file --login --commands 'echo $nu.is-login'",
nu_test_support::fs::executable_path()
))
.output() .output()
.expect("true"); .expect("failed to run nu");
assert_eq!("true\n", String::from_utf8_lossy(&child_output.stdout));
assert!(child_output.stderr.is_empty()); assert!(child_output.stderr.is_empty());
} }
#[test] #[test]
#[cfg(not(windows))]
fn run_in_not_login_mode() { fn run_in_not_login_mode() {
let child_output = std::process::Command::new("sh") let child_output = std::process::Command::new(nu_test_support::fs::executable_path())
.arg("-c") .args(["-c", "echo $nu.is-login"])
.arg(format!(
"{:?} -c 'echo $nu.is-login'",
nu_test_support::fs::executable_path()
))
.output() .output()
.expect("false"); .expect("failed to run nu");
assert_eq!("false\n", String::from_utf8_lossy(&child_output.stdout));
assert!(child_output.stderr.is_empty()); assert!(child_output.stderr.is_empty());
} }
#[test] #[test]
#[cfg(not(windows))]
fn run_in_interactive_mode() { fn run_in_interactive_mode() {
let child_output = std::process::Command::new("sh") let child_output = std::process::Command::new(nu_test_support::fs::executable_path())
.arg("-c") .args(["-i", "-c", "echo $nu.is-interactive"])
.arg(format!(
"{:?} -i -c 'echo $nu.is-interactive'",
nu_test_support::fs::executable_path()
))
.output() .output()
.expect("true"); .expect("failed to run nu");
assert_eq!("true\n", String::from_utf8_lossy(&child_output.stdout));
assert!(child_output.stderr.is_empty()); assert!(child_output.stderr.is_empty());
} }
#[test] #[test]
#[cfg(not(windows))]
fn run_in_noninteractive_mode() { fn run_in_noninteractive_mode() {
let child_output = std::process::Command::new("sh") let child_output = std::process::Command::new(nu_test_support::fs::executable_path())
.arg("-c") .args(["-c", "echo $nu.is-interactive"])
.arg(format!(
"{:?} -c 'echo $nu.is-interactive'",
nu_test_support::fs::executable_path()
))
.output() .output()
.expect("false"); .expect("failed to run nu");
assert_eq!("false\n", String::from_utf8_lossy(&child_output.stdout));
assert!(child_output.stderr.is_empty()); assert!(child_output.stderr.is_empty());
} }