mirror of
https://github.com/nushell/nushell.git
synced 2025-06-30 14:40:06 +02:00
Use IntoValue
and FromValue
derive macros in nu_plugin_example
for example usage (#13220)
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> The derive macros provided by #13031 are very useful for plugin authors. In this PR I made use of these macros for two commands. # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. --> This Example usage could be highlighted in the changelog for plugin authors as this is probably very useful for them.
This commit is contained in:
@ -1,27 +1,5 @@
|
||||
use nu_test_support::nu_with_plugins;
|
||||
|
||||
#[test]
|
||||
fn closure() {
|
||||
let actual = nu_with_plugins!(
|
||||
cwd: "tests",
|
||||
plugin: ("nu_plugin_example"),
|
||||
r#"
|
||||
$env.env_value = "value from env"
|
||||
|
||||
$env.config = {
|
||||
plugins: {
|
||||
example: {||
|
||||
$env.env_value
|
||||
}
|
||||
}
|
||||
}
|
||||
example config
|
||||
"#
|
||||
);
|
||||
|
||||
assert!(actual.out.contains("value from env"));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn none() {
|
||||
let actual = nu_with_plugins!(
|
||||
@ -34,7 +12,7 @@ fn none() {
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn record() {
|
||||
fn some() {
|
||||
let actual = nu_with_plugins!(
|
||||
cwd: "tests",
|
||||
plugin: ("nu_plugin_example"),
|
||||
@ -42,8 +20,11 @@ fn record() {
|
||||
$env.config = {
|
||||
plugins: {
|
||||
example: {
|
||||
key1: "value"
|
||||
key2: "other"
|
||||
path: "some/path",
|
||||
nested: {
|
||||
bool: true,
|
||||
string: "Hello Example!"
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
@ -51,6 +32,6 @@ fn record() {
|
||||
"#
|
||||
);
|
||||
|
||||
assert!(actual.out.contains("value"));
|
||||
assert!(actual.out.contains("other"));
|
||||
assert!(actual.out.contains("some/path"));
|
||||
assert!(actual.out.contains("Hello Example!"));
|
||||
}
|
||||
|
Reference in New Issue
Block a user