From 202d3b2d11d1e7eb2231d17fbafbf3afa365141a Mon Sep 17 00:00:00 2001 From: Jack Wright <56345+ayax79@users.noreply.github.com> Date: Mon, 14 Jul 2025 15:32:04 -0700 Subject: [PATCH] Polars limit housekeeping (#16173) # Description Removed a todo and fixed an example. --------- Co-authored-by: Jack Wright --- .../src/dataframe/command/data/sort_by_expr.rs | 3 ++- .../nu_plugin_polars/src/dataframe/command/index/arg_sort.rs | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/crates/nu_plugin_polars/src/dataframe/command/data/sort_by_expr.rs b/crates/nu_plugin_polars/src/dataframe/command/data/sort_by_expr.rs index ad8eadd7b9..6c9c9de11f 100644 --- a/crates/nu_plugin_polars/src/dataframe/command/data/sort_by_expr.rs +++ b/crates/nu_plugin_polars/src/dataframe/command/data/sort_by_expr.rs @@ -149,7 +149,8 @@ impl PluginCommand for LazySortBy { nulls_last: vec![nulls_last], multithreaded: true, maintain_order, - // todo - expose limit + // Applying a limit here will result in a panic + // it is not supported by polars in this context limit: None, }; diff --git a/crates/nu_plugin_polars/src/dataframe/command/index/arg_sort.rs b/crates/nu_plugin_polars/src/dataframe/command/index/arg_sort.rs index 1414744665..cfed012d5a 100644 --- a/crates/nu_plugin_polars/src/dataframe/command/index/arg_sort.rs +++ b/crates/nu_plugin_polars/src/dataframe/command/index/arg_sort.rs @@ -94,7 +94,7 @@ impl PluginCommand for ArgSort { ), }, Example { - description: "Returns indexes for a sorted series", + description: "Returns indexes for a sorted series and applying a limit", example: "[1 2 2 3 3] | polars into-df | polars arg-sort --limit 2", result: Some( NuDataFrame::try_from_columns(