mirror of
https://github.com/nushell/nushell.git
synced 2024-11-22 00:13:21 +01:00
Empty rest args match should be an empty list (#14246)
Fixes #14145 # User-Facing Changes An empty rest match would be `null` previously. Now it will be an empty list. This is a breaking change for any scripts relying on the old behavior. Example script: ```nu match [1] { [_ ..$rest] => { match $rest { null => { "old" } [] => { "new" } } } } ``` This expression would evaluate to "old" on current nu versions and "new" with this patch.
This commit is contained in:
parent
22ca5a6b8d
commit
20c2de9eed
@ -64,6 +64,12 @@ fn match_list_rest() {
|
||||
assert_eq!(actual.out, "single: 1 5");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn match_list_rest_empty() {
|
||||
let actual = nu!(r#"match [1] { [1 ..$rest] => { $rest == [] } }"#);
|
||||
assert_eq!(actual.out, "true");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn match_constant_1() {
|
||||
let actual = nu!(
|
||||
|
@ -48,13 +48,14 @@ impl Matcher for Pattern {
|
||||
Pattern::List(items) => match &value {
|
||||
Value::List { vals, .. } => {
|
||||
if items.len() > vals.len() {
|
||||
// The only we we allow this is to have a rest pattern in the n+1 position
|
||||
// We only allow this is to have a rest pattern in the n+1 position
|
||||
if items.len() == (vals.len() + 1) {
|
||||
match &items[vals.len()].pattern {
|
||||
Pattern::IgnoreRest => {}
|
||||
Pattern::Rest(var_id) => {
|
||||
matches.push((*var_id, Value::nothing(items[vals.len()].span)))
|
||||
}
|
||||
Pattern::Rest(var_id) => matches.push((
|
||||
*var_id,
|
||||
Value::list(Vec::new(), items[vals.len()].span),
|
||||
)),
|
||||
_ => {
|
||||
// There is a pattern which can't skip missing values, so we fail
|
||||
return false;
|
||||
|
Loading…
Reference in New Issue
Block a user