From 2770a6f5e47cea7bf0560b024fa9f08cf4dab4c0 Mon Sep 17 00:00:00 2001 From: Sam Hedin Date: Sat, 6 Jun 2020 13:01:55 +0200 Subject: [PATCH] Remove notes I made --- post.org | 29 ----------------------------- 1 file changed, 29 deletions(-) delete mode 100644 post.org diff --git a/post.org b/post.org deleted file mode 100644 index 96bea39dbc..0000000000 --- a/post.org +++ /dev/null @@ -1,29 +0,0 @@ -# WIP: Per directory env-variables -For #86 - -Environment variables are added if you have created a file called .nu inside a whitelisted directory, formatted as shown below. (I am, of course, open to change everything about this) -``` -[env] -var = "value" -anothervar = "anothervalue" -``` - -In order for a .nu-file to be read, the directory it is in must be listed in the `nu_env_dirs` variable in nushell's `config.toml`. -``` -nu_env_dirs = ["/home/sam", "/home/sam/github", "/home/sam/github/test"] -``` -This was implemented for the sake of security. I do not believe that it is appropiate for nushell to pick up random .nu-files unless -the user has explicitly said that it's alright. An adversary could hide a .nu-file in an otherwise unsuspicious folder that you download, -and now you suddenly have nushell picking up whatever environment variables they set. -This meant that the code necessarily become more involved than just looking for a .nu-file in the current directory and applying its variables, -but this extra code also allowed for some other nice features and behavior which is listed below. - -Behavior: -- If you are in a directory, or a subdirectory to a directory with a .nu-file, the vars in that .nu-file are applied. -- If you leave a directory which set some variables, the variables are unset. -- If a directory contains a .nu with an environment variable already set, the old value will be overwritten with the value from the .nu. This holds even if the old value was set by a .nu in a parent directory. - - The overwritten value is restored when you leave the directory. - ----- - -# \ No newline at end of file