From 33303f083c0fbc33cfb552368d56cd07d6cbb4f0 Mon Sep 17 00:00:00 2001 From: 132ikl <132@ikl.sh> Date: Mon, 2 Jun 2025 16:34:45 -0400 Subject: [PATCH] Disable flaky killing_job_kills_pids test on macOS (#15874) # Description This test has failed a number of times specifically on macOS. I'm not exactly sure what the issue is, it seemed to work fine before. We should probably actually fix it, but flaky CI is worse than missing this one test on macOS cc @cosineblast --- crates/nu-command/tests/commands/job.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/crates/nu-command/tests/commands/job.rs b/crates/nu-command/tests/commands/job.rs index 608ca318c8..49796c900c 100644 --- a/crates/nu-command/tests/commands/job.rs +++ b/crates/nu-command/tests/commands/job.rs @@ -285,7 +285,10 @@ fn killing_job_removes_it_from_table() { assert_eq!(actual.out, "[true, true, true, true]"); } +// this test is unreliable on the macOS CI, but it worked fine for a couple months. +// still works on other operating systems. #[test] +#[cfg(not(target_os = "macos"))] fn killing_job_kills_pids() { let actual = nu!(format!( r#"