extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-21 09:40:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: clippy warning of rust 1.8.4 (#14984)

Browse Source 
# Description

I'm on rust toolchain 1.8.4, and I can see clippy warnings that can't be
caught by the ci workflow, primarily related to lifetime params.

I think it doesn't hurt to fix those in advance.

# User-Facing Changes

# Tests + Formatting

# After Submitting
This commit is contained in:
zc he
2025-02-02 21:56:54 +08:00
committed by GitHub
parent 5291f978c2
commit 339c5b7c83
16 changed files with 54 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
crates/nu-protocol/src/value/mod.rs
View File

@@ -2512,7 +2512,7 @@ impl PartialOrd for Value {
impl PartialEq for Value {
fn eq(&self, other: &Self) -> bool {
self.partial_cmp(other).map_or(false, Ordering::is_eq)
self.partial_cmp(other).is_some_and(Ordering::is_eq)
}
}

16
crates/nu-protocol/src/value/record.rs
View File

@@ -440,13 +440,13 @@ impl<'a> Iterator for Iter<'a> {
}
}
impl<'a> DoubleEndedIterator for Iter<'a> {
impl DoubleEndedIterator for Iter<'_> {
fn next_back(&mut self) -> Option<Self::Item> {
self.iter.next_back().map(|(col, val): &(_, _)| (col, val))
}
}
impl<'a> ExactSizeIterator for Iter<'a> {
impl ExactSizeIterator for Iter<'_> {
fn len(&self) -> usize {
self.iter.len()
}
@@ -482,13 +482,13 @@ impl<'a> Iterator for IterMut<'a> {
}
}
impl<'a> DoubleEndedIterator for IterMut<'a> {
impl DoubleEndedIterator for IterMut<'_> {
fn next_back(&mut self) -> Option<Self::Item> {
self.iter.next_back().map(|(col, val)| (&*col, val))
}
}
impl<'a> ExactSizeIterator for IterMut<'a> {
impl ExactSizeIterator for IterMut<'_> {
fn len(&self) -> usize {
self.iter.len()
}
@@ -524,13 +524,13 @@ impl<'a> Iterator for Columns<'a> {
}
}
impl<'a> DoubleEndedIterator for Columns<'a> {
impl DoubleEndedIterator for Columns<'_> {
fn next_back(&mut self) -> Option<Self::Item> {
self.iter.next_back().map(|(col, _)| col)
}
}
impl<'a> ExactSizeIterator for Columns<'a> {
impl ExactSizeIterator for Columns<'_> {
fn len(&self) -> usize {
self.iter.len()
}
@@ -584,13 +584,13 @@ impl<'a> Iterator for Values<'a> {
}
}
impl<'a> DoubleEndedIterator for Values<'a> {
impl DoubleEndedIterator for Values<'_> {
fn next_back(&mut self) -> Option<Self::Item> {
self.iter.next_back().map(|(_, val)| val)
}
}
impl<'a> ExactSizeIterator for Values<'a> {
impl ExactSizeIterator for Values<'_> {
fn len(&self) -> usize {
self.iter.len()
}