extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-06-30 06:30:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove pythonic int * list behavior (#10292)

Browse Source 
# Description
The pythonism that multiplying a scalar integer with a list results in a
repeated concatenation of the list, is ambiguous with other possible
interpretations and thus actively harmful to clear semantics in nushell.

Another possible reading of this scalar/vector product would be trying
to perform elementwise multiplication with the scalar.

Before we bless this alternative as a more reasonable design the best
course of action is to remove this pythonism.

Work related to #10233


# User-Facing Changes
Breaking change as this turns `int * list` or `list * int` into hard
errors.

# Tests + Formatting
Remove the associated test
This commit is contained in:
Stefan Holderbach
2023-09-13 00:43:49 +02:00
committed by GitHub
parent ba6d8ad261
commit 3e14dc3eb8
3 changed files with 0 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
crates/nu-command/tests/commands/math/mod.rs
View File

@ -506,11 +506,3 @@ fn int_multiple_string() {
let actual = nu!(pipeline(r#""ab" * 3"#));
assert_eq!(actual.out, "ababab");
}
#[test]
fn int_multiple_list() {
let actual = nu!(pipeline(r#"3 * [1 2] | to nuon"#));
assert_eq!(actual.out, "[1, 2, 1, 2, 1, 2]");
let actual = nu!(pipeline(r#"[1 2] * 3 | to nuon"#));
assert_eq!(actual.out, "[1, 2, 1, 2, 1, 2]");
}