Remove pythonic int * list behavior (#10292)

# Description
The pythonism that multiplying a scalar integer with a list results in a
repeated concatenation of the list, is ambiguous with other possible
interpretations and thus actively harmful to clear semantics in nushell.

Another possible reading of this scalar/vector product would be trying
to perform elementwise multiplication with the scalar.

Before we bless this alternative as a more reasonable design the best
course of action is to remove this pythonism.

Work related to #10233


# User-Facing Changes
Breaking change as this turns `int * list` or `list * int` into hard
errors.

# Tests + Formatting
Remove the associated test
This commit is contained in:
Stefan Holderbach
2023-09-13 00:43:49 +02:00
committed by GitHub
parent ba6d8ad261
commit 3e14dc3eb8
3 changed files with 0 additions and 24 deletions

View File

@ -241,8 +241,6 @@ pub fn math_result_type(
(Type::Float, Type::Duration) => (Type::Duration, None),
(Type::Int, Type::String) => (Type::String, None),
(Type::String, Type::Int) => (Type::String, None),
(Type::Int, Type::List(a)) => (Type::List(a.clone()), None),
(Type::List(a), Type::Int) => (Type::List(a.clone()), None),
(Type::Custom(a), Type::Custom(b)) if a == b => (Type::Custom(a.to_string()), None),
(Type::Custom(a), _) => (Type::Custom(a.to_string()), None),