Fix(tests/nu-command): remove unnecessary cwd() and pipeline(), etc (#8711)

# Description

This PR aims to cover the tests under nu-command as part of this issue
#8670 to clean up any unnecessary wrapping funcs like `cwd(".")` or
`pipeline()`, etc.

This PR is still WIP and opening as draft to get first impressions and
feedback on a few tests before I go on changing more.


# User-Facing Changes

None

# Tests + Formatting

None

# After Submitting

None

---------

Signed-off-by: Harshal Chaudhari <harshal.chaudhary@gmail.com>
Co-authored-by: Reilly Wood <reilly.wood@icloud.com>
This commit is contained in:
Harshal Chaudhari
2023-04-02 16:25:05 +01:00
committed by GitHub
parent 61fa826159
commit 3fab427383
4 changed files with 35 additions and 156 deletions

View File

@ -2,8 +2,7 @@ use nu_test_support::{nu, pipeline};
#[test]
fn checks_any_row_is_true() {
let actual = nu!(
cwd: ".", pipeline(
let actual = nu!(pipeline(
r#"
echo [ "Ecuador", "USA", "New Zealand" ]
| any {|it| $it == "New Zealand" }
@ -15,8 +14,7 @@ fn checks_any_row_is_true() {
#[test]
fn checks_any_column_of_a_table_is_true() {
let actual = nu!(
cwd: ".", pipeline(
let actual = nu!(pipeline(
r#"
echo [
[ first_name, last_name, rusty_at, likes ];
@ -35,8 +33,7 @@ fn checks_any_column_of_a_table_is_true() {
#[test]
fn checks_if_any_returns_error_with_invalid_command() {
// Using `with-env` to remove `st` possibly being an external program
let actual = nu!(
cwd: ".", pipeline(
let actual = nu!(pipeline(
r#"
with-env {PATH: ""} {
[red orange yellow green blue purple] | any {|it| ($it | st length) > 4 }
@ -49,50 +46,35 @@ fn checks_if_any_returns_error_with_invalid_command() {
#[test]
fn works_with_1_param_blocks() {
let actual = nu!(
cwd: ".", pipeline(
r#"[1 2 3] | any {|e| print $e | false }"#
));
let actual = nu!(r#"[1 2 3] | any {|e| print $e | false }"#);
assert_eq!(actual.out, "123false");
}
#[test]
fn works_with_0_param_blocks() {
let actual = nu!(
cwd: ".", pipeline(
r#"[1 2 3] | any {|| print $in | false }"#
));
let actual = nu!(r#"[1 2 3] | any {|| print $in | false }"#);
assert_eq!(actual.out, "123false");
}
#[test]
fn early_exits_with_1_param_blocks() {
let actual = nu!(
cwd: ".", pipeline(
r#"[1 2 3] | any {|e| print $e | true }"#
));
let actual = nu!(r#"[1 2 3] | any {|e| print $e | true }"#);
assert_eq!(actual.out, "1true");
}
#[test]
fn early_exits_with_0_param_blocks() {
let actual = nu!(
cwd: ".", pipeline(
r#"[1 2 3] | any {|| print $in | true }"#
));
let actual = nu!(r#"[1 2 3] | any {|| print $in | true }"#);
assert_eq!(actual.out, "1true");
}
#[test]
fn any_uses_enumerate_index() {
let actual = nu!(
cwd: ".", pipeline(
r#"[7 8 9] | enumerate | any {|el| print $el.index | false }"#
));
let actual = nu!(r#"[7 8 9] | enumerate | any {|el| print $el.index | false }"#);
assert_eq!(actual.out, "012false");
}