extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-06-30 22:50:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix "Char index out of bounds" Error (#11526)

Browse Source 
# Description

The code that converts Nushell's span into LSP line and character
indices accidentally treated the span as character indices while they
are byte indices. Fixes #11522.

# User-Facing Changes

None, just a bugfix.
This commit is contained in:
Marc Schreiber
2024-01-11 22:24:49 +01:00
committed by GitHub
parent 0ebbc8f71c
commit 41119d3f88
5 changed files with 89 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
crates/nu-lsp/src/notification.rs
View File

@ -95,7 +95,7 @@ mod tests {
use lsp_types::{Range, Url};
use nu_test_support::fs::fixtures;
use crate::tests::{hover, initialize_language_server, open, update};
use crate::tests::{hover, initialize_language_server, open, open_unchecked, update};
#[test]
fn hover_correct_documentation_on_let() {
@ -107,7 +107,7 @@ mod tests {
script.push("var.nu");
let script = Url::from_file_path(script).unwrap();
open(&client_connection, script.clone());
open_unchecked(&client_connection, script.clone());
let resp = hover(&client_connection, script.clone(), 0, 0);
let result = if let Message::Response(response) = resp {
@ -137,7 +137,7 @@ mod tests {
script.push("command.nu");
let script = Url::from_file_path(script).unwrap();
open(&client_connection, script.clone());
open_unchecked(&client_connection, script.clone());
update(
&client_connection,
script.clone(),
@ -178,7 +178,7 @@ hello"#,
script.push("command.nu");
let script = Url::from_file_path(script).unwrap();
open(&client_connection, script.clone());
open_unchecked(&client_connection, script.clone());
update(
&client_connection,
script.clone(),
@ -212,4 +212,19 @@ hello"#,
})
);
}
#[test]
fn open_document_with_utf_char() {
let (client_connection, _recv) = initialize_language_server();
let mut script = fixtures();
script.push("lsp");
script.push("notifications");
script.push("issue_11522.nu");
let script = Url::from_file_path(script).unwrap();
let result = open(&client_connection, script);
assert_eq!(result.map(|_| ()), Ok(()))
}
}