extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-09 02:45:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

Further cleanup of Span::test_data usage + span fixes (#7595)

Browse Source 
# Description

Inspired by #7592

For brevity use `Value::test_{string,int,float,bool}`

Includes fixes to commands that were abusing `Span::test_data` in their
implementation. Now the call span is used where possible or the explicit
`Span::unknonw` is used.

## Command fixes
- Fix abuse of `Span::test_data()` in `query_xml`
- Fix abuse of `Span::test_data()` in `term size`
- Fix abuse of `Span::test_data()` in `seq date`
- Fix two abuses of `Span::test_data` in `nu-cli`
- Change `Span::test_data` to `Span::unknown` in `keybindings listen`
- Add proper call span to `registry query`
- Fix span use in `nu_plugin_query`
- Fix span assignment in `select`
- Use `Span::unknown` instead of `test_data` in more places

## Other
- Use `Value::test_int`/`test_float()` consistently
- More `test_string` and `test_bool`
- Fix unused imports


# User-Facing Changes

Some commands may now provide more helpful spans for downstream use in
errors
This commit is contained in:
Stefan Holderbach
2022-12-24 14:41:57 +01:00
committed by GitHub
parent dd6fe6a04a
commit 45fe3be83e
59 changed files with 236 additions and 310 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
crates/nu-command/src/strings/str_/trim/trim_.rs
View File

@ -302,7 +302,7 @@ mod tests {
cols: cols.iter().map(|x| x.to_string()).collect(),
vals: vals
.iter()
.map(|x| Value::string(x.to_string(), Span::test_data()))
.map(|x| Value::test_string(x.to_string()))
.collect(),
span: Span::test_data(),
}
@ -312,7 +312,7 @@ mod tests {
Value::List {
vals: vals
.iter()
.map(|x| Value::string(x.to_string(), Span::test_data()))
.map(|x| Value::test_string(x.to_string()))
.collect(),
span: Span::test_data(),
}
@ -477,7 +477,7 @@ mod tests {
let row = Value::List {
vals: vec![
Value::test_string(" nu shell "),
Value::int(65, Span::test_data()),
Value::test_int(65),
Value::test_string(" d"),
],
span: Span::test_data(),
@ -485,7 +485,7 @@ mod tests {
let expected = Value::List {
vals: vec![
Value::test_string("nushell"),
Value::int(65, Span::test_data()),
Value::test_int(65),
Value::test_string("d"),
],
span: Span::test_data(),
@ -549,7 +549,7 @@ mod tests {
let row = Value::List {
vals: vec![
Value::test_string("##nu####shell##"),
Value::int(65, Span::test_data()),
Value::test_int(65),
Value::test_string("#d"),
],
span: Span::test_data(),
@ -557,7 +557,7 @@ mod tests {
let expected = Value::List {
vals: vec![
Value::test_string("nushell"),
Value::int(65, Span::test_data()),
Value::test_int(65),
Value::test_string("d"),
],
span: Span::test_data(),
@ -659,7 +659,7 @@ mod tests {
let row = Value::List {
vals: vec![
Value::test_string(" a "),
Value::int(65, Span::test_data()),
Value::test_int(65),
Value::test_string(" d"),
],
span: Span::test_data(),
@ -667,7 +667,7 @@ mod tests {
let expected = Value::List {
vals: vec![
Value::test_string("a "),
Value::int(65, Span::test_data()),
Value::test_int(65),
Value::test_string("d"),
],
span: Span::test_data(),
@ -784,7 +784,7 @@ mod tests {
let row = Value::List {
vals: vec![
Value::test_string(" a "),
Value::int(65, Span::test_data()),
Value::test_int(65),
Value::test_string(" d"),
],
span: Span::test_data(),
@ -792,7 +792,7 @@ mod tests {
let expected = Value::List {
vals: vec![
Value::test_string(" a"),
Value::int(65, Span::test_data()),
Value::test_int(65),
Value::test_string(" d"),
],
span: Span::test_data(),
@ -911,7 +911,7 @@ mod tests {
let row = Value::List {
vals: vec![
Value::test_string(" a b c d "),
Value::int(65, Span::test_data()),
Value::test_int(65),
Value::test_string(" b c d e f"),
],
span: Span::test_data(),
@ -919,7 +919,7 @@ mod tests {
let expected = Value::List {
vals: vec![
Value::test_string("a b c d"),
Value::int(65, Span::test_data()),
Value::test_int(65),
Value::test_string("b c d e f"),
],
span: Span::test_data(),