extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-06-30 22:50:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

str collect => str join (#6531)

Browse Source 
* Initialize join.rs as a copy of collect.rs

* Evolve StrCollect into StrJoin

* Replace 'str collect' with 'str join' everywhere

git ls-files | lines | par-each { |it| sed -i 's,str collect,str join,g' $it }

* Deprecate 'str collect'

* Revert "Deprecate 'str collect'"

This reverts commit 959d14203e.

* Change `str collect` help message to say that it is deprecated

We cannot remove `str collect` currently (i.e. via
`nu_protocol::ShellError::DeprecatedCommand` since a prominent project
uses the API:

b85542c31c/src/virtualenv/activation/nushell/activate.nu (L43)
This commit is contained in:
Dan Davison
2022-09-11 04:48:27 -04:00
committed by GitHub
parent 9ee4086dfa
commit 4926865c4e
29 changed files with 173 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/tests/test_parser.rs
View File

@ -245,7 +245,7 @@ def 'call-me' [] {
echo $CONST_A
}
[(say-hi) (call-me)] | str collect
[(say-hi) (call-me)] | str join
"#,
"HelloHello",
@ -266,7 +266,7 @@ def 'say-hi' [] {
echo (call-me)
}
[(say-hi) (call-me)] | str collect
[(say-hi) (call-me)] | str join
"#,
"HelloHello",
@ -287,7 +287,7 @@ def 'call-me' [] {
echo $CONST_A
}
[(call-me) (say-hi)] | str collect
[(call-me) (say-hi)] | str join
"#,
"HelloHello",
@ -308,7 +308,7 @@ def 'say-hi' [] {
echo (call-me)
}
[(call-me) (say-hi)] | str collect
[(call-me) (say-hi)] | str join
"#,
"HelloHello",
@ -318,7 +318,7 @@ def 'say-hi' [] {
#[test]
fn capture_row_condition() -> TestResult {
run_test(
r#"let name = "foo"; [foo] | where $'($name)' =~ $it | str collect"#,
r#"let name = "foo"; [foo] | where $'($name)' =~ $it | str join"#,
"foo",
)
}
@ -326,7 +326,7 @@ fn capture_row_condition() -> TestResult {
#[test]
fn starts_with_operator_succeeds() -> TestResult {
run_test(
r#"[Moe Larry Curly] | where $it starts-with L | str collect"#,
r#"[Moe Larry Curly] | where $it starts-with L | str join"#,
"Larry",
)
}
@ -334,7 +334,7 @@ fn starts_with_operator_succeeds() -> TestResult {
#[test]
fn ends_with_operator_succeeds() -> TestResult {
run_test(
r#"[Moe Larry Curly] | where $it ends-with ly | str collect"#,
r#"[Moe Larry Curly] | where $it ends-with ly | str join"#,
"Curly",
)
}