mirror of
https://github.com/nushell/nushell.git
synced 2025-08-09 21:47:46 +02:00
Replaced IoError::new_with_additional_context
calls that still had Span::unknown()
(#15056)
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> In #14968 I grepped the code for `IoError::new` calls with unknown spans, but I forgot to also grep for `IoError::new_with_additional_context`, so I missed some. Hopefullly this is the last P.S. to #14968. # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> N/A # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. --> N/A
This commit is contained in:
@ -324,12 +324,7 @@ impl EngineState {
|
||||
|
||||
let cwd = self.cwd(Some(stack))?;
|
||||
std::env::set_current_dir(cwd).map_err(|err| {
|
||||
IoError::new_with_additional_context(
|
||||
err.kind(),
|
||||
Span::unknown(),
|
||||
None,
|
||||
"Could not set current dir",
|
||||
)
|
||||
IoError::new_internal(err.kind(), "Could not set current dir", crate::location!())
|
||||
})?;
|
||||
|
||||
if let Some(config) = stack.config.take() {
|
||||
@ -521,11 +516,11 @@ impl EngineState {
|
||||
if err.kind() == std::io::ErrorKind::NotFound {
|
||||
Ok(PluginRegistryFile::default())
|
||||
} else {
|
||||
Err(ShellError::Io(IoError::new_with_additional_context(
|
||||
Err(ShellError::Io(IoError::new_internal_with_path(
|
||||
err.kind(),
|
||||
Span::unknown(),
|
||||
PathBuf::from(plugin_path),
|
||||
"Failed to open plugin file",
|
||||
crate::location!(),
|
||||
PathBuf::from(plugin_path),
|
||||
)))
|
||||
}
|
||||
}
|
||||
@ -538,11 +533,11 @@ impl EngineState {
|
||||
|
||||
// Write it to the same path
|
||||
let plugin_file = File::create(plugin_path.as_path()).map_err(|err| {
|
||||
IoError::new_with_additional_context(
|
||||
IoError::new_internal_with_path(
|
||||
err.kind(),
|
||||
Span::unknown(),
|
||||
PathBuf::from(plugin_path),
|
||||
"Failed to write plugin file",
|
||||
crate::location!(),
|
||||
PathBuf::from(plugin_path),
|
||||
)
|
||||
})?;
|
||||
|
||||
|
Reference in New Issue
Block a user