mirror of
https://github.com/nushell/nushell.git
synced 2025-07-02 23:51:49 +02:00
Enforce call stack depth limit for all calls (#11729)
# Description Previously, only direcly-recursive calls were checked for recursion depth. But most recursive calls in nushell are mutually recursive since expressions like `for`, `where`, `try` and `do` all execute a separte block. ```nushell def f [] { do { f } } ``` Calling `f` would crash nushell with a stack overflow. I think the only general way to prevent such a stack overflow is to enforce a maximum call stack depth instead of only disallowing directly recursive calls. This commit also moves that logic into `eval_call()` instead of `eval_block()` because the recursion limit is tracked in the `Stack`, but not all blocks are evaluated in a new stack. Incrementing the recursion depth of the caller's stack would permanently increment that for all future calls. Fixes #11667 # User-Facing Changes Any function call can now fail with `recursion_limit_reached` instead of just directly recursive calls. Mutually-recursive calls no longer crash nushell. # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
This commit is contained in:
@ -10,7 +10,6 @@ pub struct Block {
|
||||
pub captures: Vec<VarId>,
|
||||
pub redirect_env: bool,
|
||||
pub span: Option<Span>, // None option encodes no span to avoid using test_span()
|
||||
pub recursive: Option<bool>, // does the block call itself?
|
||||
}
|
||||
|
||||
impl Block {
|
||||
@ -51,7 +50,6 @@ impl Block {
|
||||
captures: vec![],
|
||||
redirect_env: false,
|
||||
span: None,
|
||||
recursive: None,
|
||||
}
|
||||
}
|
||||
|
||||
@ -62,7 +60,6 @@ impl Block {
|
||||
captures: vec![],
|
||||
redirect_env: false,
|
||||
span: None,
|
||||
recursive: None,
|
||||
}
|
||||
}
|
||||
|
||||
@ -97,7 +94,6 @@ where
|
||||
captures: vec![],
|
||||
redirect_env: false,
|
||||
span: None,
|
||||
recursive: None,
|
||||
}
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user