extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-09 03:34:58 +02:00
Code Issues Packages Projects Releases Wiki Activity

nu-cli: added tests for file completions (#5232)

Browse Source 
* nu-cli: added tests for file completions

* test adding extra sort

* Feature/refactor completion options (#5228)

* Copy completion filter to custom completions

* Remove filter function from completer

This function was a no-op for FileCompletion and CommandCompletion.
Flag- and VariableCompletion just filters with `starts_with` which
happens in both completers anyway and should therefore also be a no-op.
The remaining use case in CustomCompletion was moved into the
CustomCompletion source file.

Filtering should probably happen immediately while fetching completions
to avoid unnecessary memory allocations.

* Add get_sort_by() to Completer trait

* Remove CompletionOptions from Completer::fetch()

* Fix clippy lints

* Apply Completer changes to DotNuCompletion

* add os to $nu based on rust's understanding (#5243)

* add os to $nu based on rust's understanding

* add a few more constants

Co-authored-by: Richard <Tropid@users.noreply.github.com>
Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>
This commit is contained in:
Herlon Aguiar
2022-04-20 06:54:00 +02:00
committed by GitHub
parent f2d47f97da
commit 4d7b86f278
12 changed files with 93 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
crates/nu-cli/src/completions/file_completions.rs
View File

@ -60,6 +60,7 @@ impl Completer for FileCompletion {
// Sort items
let mut sorted_items = items;
sorted_items.sort_by(|a, b| a.value.cmp(&b.value));
sorted_items.sort_by(|a, b| {
let a_distance = levenshtein_distance(&prefix_str, &a.value);
let b_distance = levenshtein_distance(&prefix_str, &b.value);

2
crates/nu-cli/src/lib.rs
View File

@ -15,7 +15,7 @@ mod util;
mod validation;
pub use commands::evaluate_commands;
pub use completions::NuCompleter;
pub use completions::{FileCompletion, NuCompleter};
pub use config_files::eval_config_contents;
pub use errors::CliError;
pub use eval_file::evaluate_file;