extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-09 15:06:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

Some iter perf improvements

Browse Source
This commit is contained in:
JT
2021-10-26 16:22:37 +13:00
parent e039e5f6a4
commit 543c566ccc
2 changed files with 16 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
crates/nu-command/src/core_commands/for_.rs
View File

@ -56,18 +56,17 @@ impl Command for For {
.expect("internal error: expected block");
let engine_state = engine_state.clone();
let block = engine_state.get_block(block_id);
let block = engine_state.get_block(block_id).clone();
let mut stack = stack.collect_captures(&block.captures);
match values {
Value::List { vals, .. } => Ok(vals
.into_iter()
.map(move |x| {
let mut stack = stack.clone();
stack.add_var(var_id, x);
let block = engine_state.get_block(block_id);
match eval_block(&engine_state, &mut stack, block, PipelineData::new()) {
//let block = engine_state.get_block(block_id);
match eval_block(&engine_state, &mut stack, &block, PipelineData::new()) {
Ok(pipeline_data) => pipeline_data.into_value(),
Err(error) => Value::Error { error },
}
@ -78,8 +77,8 @@ impl Command for For {
.map(move |x| {
stack.add_var(var_id, x);
let block = engine_state.get_block(block_id);
match eval_block(&engine_state, &mut stack, block, PipelineData::new()) {
//let block = engine_state.get_block(block_id);
match eval_block(&engine_state, &mut stack, &block, PipelineData::new()) {
Ok(pipeline_data) => pipeline_data.into_value(),
Err(error) => Value::Error { error },
}
@ -88,7 +87,7 @@ impl Command for For {
x => {
stack.add_var(var_id, x);
eval_block(&engine_state, &mut stack, block, PipelineData::new())
eval_block(&engine_state, &mut stack, &block, PipelineData::new())
}
}
}