mirror of
https://github.com/nushell/nushell.git
synced 2025-08-10 00:38:56 +02:00
support blink cursor, and fix underscore's cursorshape (#8990)
# Description Close: #8988 Thanks to new crossterm version, nushell can support blink cursor shape. It can be config with the following value: 1. blink_block 2. blink_line 3. blink_underscore And original block, line, underscore will be steady. It also fixes wrong shape of `underscore`. # User-Facing Changes Here is a little breaking change, before the change: `line` cursor shape is blinking line, but after this pr, it will be `steady line`. To make a blink line, we need to change the value to `blink_line`. But I think it's ok, because after the change, we have a good naming convention about the name of shape # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- crates/nu-std/tests/run.nu` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
This commit is contained in:
@ -716,8 +716,11 @@ pub fn evaluate_repl(
|
||||
fn map_nucursorshape_to_cursorshape(shape: NuCursorShape) -> SetCursorStyle {
|
||||
match shape {
|
||||
NuCursorShape::Block => SetCursorStyle::SteadyBlock,
|
||||
NuCursorShape::UnderScore => SetCursorStyle::DefaultUserShape,
|
||||
NuCursorShape::Line => SetCursorStyle::BlinkingBar,
|
||||
NuCursorShape::UnderScore => SetCursorStyle::SteadyUnderScore,
|
||||
NuCursorShape::Line => SetCursorStyle::SteadyBar,
|
||||
NuCursorShape::BlinkBlock => SetCursorStyle::BlinkingBlock,
|
||||
NuCursorShape::BlinkUnderScore => SetCursorStyle::BlinkingUnderScore,
|
||||
NuCursorShape::BlinkLine => SetCursorStyle::BlinkingBar,
|
||||
}
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user