mirror of
https://github.com/nushell/nushell.git
synced 2025-08-15 21:37:53 +02:00
Move CLI related commands to nu-cli
(#8832)
# Description Part of the larger cratification effort. Moves all `reedline` or shell line editor specific commands to `nu-cli`. ## From `nu-cmd-lang`: - `commandline` - This shouldn't have moved there. Doesn't directly depend on reedline but assumes parts in the engine state that are specific to the use of reedline or a REPL ## From `nu-command`: - `keybindings` and subcommands - `keybindings default` - `keybindings list` - `keybindings listen` - very `reedline` specific - `history` - needs `reedline` - `history session` ## internal use Instead of having a separate `create_default_context()` that calls `nu-command`'s `create_default_context()`, I added a `add_cli_context()` that updates an `EngineState` # User-Facing Changes None ## Build time comparison `cargo build --timings` from a `cargo clean --profile dev` ### total main: 64 secs this: 59 secs ### `nu-command` build time branch | total| codegen | fraction ---|---|---|--- main | 14.0s | 6.2s | (44%) this | 12.5s | 5.5s | (44%) `nu-cli` depends on `nu-command` at the moment. Thus it is built during the code-gen phase of `nu-command` (on 16 virtual cores) # Tests + Formatting I removed the `test_example()` facilities for now as we had not run any of the commands in an `Example` test and importing the right context for those tests seemed more of a hassle than the duplicated `test_examples()` implementations in `nu-cmd-lang` and `nu-command`
This commit is contained in:
committed by
GitHub
parent
58b96fdede
commit
57510f2fd2
@ -42,7 +42,7 @@ fn main() -> Result<()> {
|
||||
|
||||
// Get initial current working directory.
|
||||
let init_cwd = get_init_cwd();
|
||||
let mut engine_state = create_default_context();
|
||||
let mut engine_state = nu_cli::add_cli_context(create_default_context());
|
||||
|
||||
// Custom additions
|
||||
let delta = {
|
||||
|
@ -172,7 +172,7 @@ pub fn nu_repl() {
|
||||
let cwd = std::env::current_dir().expect("Could not get current working directory.");
|
||||
let source_lines = args();
|
||||
|
||||
let mut engine_state = create_default_context();
|
||||
let mut engine_state = nu_cli::add_cli_context(create_default_context());
|
||||
let mut stack = Stack::new();
|
||||
|
||||
stack.add_env_var("PWD".to_string(), Value::test_string(cwd.to_string_lossy()));
|
||||
|
Reference in New Issue
Block a user