mirror of
https://github.com/nushell/nushell.git
synced 2025-08-09 19:07:42 +02:00
fixes a def parsing bug with a default list (#8096)
# Description This PR fixes a bug where a default list in a custom command parameter wasn't being accepted. The reason was because it was comparing specific types of list like `list<any>` != `list<string>`. So, this PR attempts to fix that. ### Before ``` > def f [param: list = [one]] { echo $param } Error: nu::parser::assignment_mismatch (link) × Default value wrong type ╭─[entry #1:1:1] 1 │ def f [param: list = [one]] { echo $param } · ──┬── · ╰── default value not list<any> ╰──── ``` ### After ``` > def f [param: list = [one]] {echo $param} > f ╭───┬─────╮ │ 0 │ one │ ╰───┴─────╯ ``` closes #8092 # User-Facing Changes # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
This commit is contained in:
@ -3662,6 +3662,25 @@ pub fn parse_signature_helper(
|
||||
expression.ty.clone(),
|
||||
);
|
||||
}
|
||||
Type::List(_) => {
|
||||
if var_type.is_list() && expression.ty.is_list() {
|
||||
working_set.set_variable_type(
|
||||
var_id,
|
||||
expression.ty.clone(),
|
||||
);
|
||||
} else {
|
||||
error = error.or_else(|| {
|
||||
Some(ParseError::AssignmentMismatch(
|
||||
"Default value wrong type".into(),
|
||||
format!(
|
||||
"default value not {0}",
|
||||
expression.ty
|
||||
),
|
||||
expression.span,
|
||||
))
|
||||
})
|
||||
}
|
||||
}
|
||||
t => {
|
||||
if t != &expression.ty {
|
||||
error = error.or_else(|| {
|
||||
|
Reference in New Issue
Block a user