extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2024-12-26 08:59:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix tests for cargo.exe check command (#11022)

Browse Source 
This pull request fixes the tests for the `cargo.exe check` command. The
tests were failing due `cargo check -h` sometimes reporting `cargo.exe`
as the binary and thus not containing `cargo check` in the output.

The fix involves using the `Command` module from the `std::process`
library to run the command and comparing its output to the expected
output. No changes were made to the codebase itself.
This commit is contained in:
Gaëtan 2023-11-10 21:15:11 +01:00 committed by GitHub
parent 93096a07aa
commit 588a078872
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/tests/test_known_external.rs
View File

@ -1,3 +1,5 @@
use std::process::Command;
use crate::tests::{fail_test, run_test, run_test_contains, TestResult}; use crate::tests::{fail_test, run_test, run_test_contains, TestResult};
// cargo version prints a string of the form: // cargo version prints a string of the form:
@ -107,7 +109,8 @@ fn known_external_misc_values() -> TestResult {
/// GitHub issue #7822 /// GitHub issue #7822
#[test] #[test]
fn known_external_subcommand_from_module() -> TestResult { fn known_external_subcommand_from_module() -> TestResult {
run_test_contains( let output = Command::new("cargo").arg("check").arg("-h").output()?;
run_test(
r#" r#"
module cargo { module cargo {
export extern check [] export extern check []
@ -115,14 +118,15 @@ fn known_external_subcommand_from_module() -> TestResult {
use cargo; use cargo;
cargo check -h cargo check -h
"#, "#,
"cargo check", String::from_utf8(output.stdout)?.trim(),
) )
} }
/// GitHub issue #7822 /// GitHub issue #7822
#[test] #[test]
fn known_external_aliased_subcommand_from_module() -> TestResult { fn known_external_aliased_subcommand_from_module() -> TestResult {
run_test_contains( let output = Command::new("cargo").arg("check").arg("-h").output()?;
run_test(
r#" r#"
module cargo { module cargo {
export extern check [] export extern check []
@ -131,6 +135,6 @@ fn known_external_aliased_subcommand_from_module() -> TestResult {
alias cc = cargo check; alias cc = cargo check;
cc -h cc -h
"#, "#,
"cargo check", String::from_utf8(output.stdout)?.trim(),
) )
} }