mirror of
https://github.com/nushell/nushell.git
synced 2025-06-30 22:50:14 +02:00
Fix return
in filter
closure eval (#12292)
# Description Closes https://github.com/nushell/nushell/issues/12257 This was down to the use of `eval_block` instead of `eval_block_with_early_return`. We may want to reconsider how we differentiate between this behavior. We currently need to check all the remaining commands that can invoke a closure block, if they properly handle `ShellError::Return` as a passing of a `Value` - **Add test for `return` in `filter` closure** - **Fix use of `return` in `filter` closure** # User-Facing Changes You can now return a value from a `filter` closure # Tests + Formatting Regression test
This commit is contained in:
committed by
GitHub
parent
b70766e6f5
commit
592dc4bbfa
18
crates/nu-command/tests/commands/filter.rs
Normal file
18
crates/nu-command/tests/commands/filter.rs
Normal file
@ -0,0 +1,18 @@
|
||||
use nu_test_support::{nu, pipeline};
|
||||
|
||||
#[test]
|
||||
fn filter_with_return_in_closure() {
|
||||
let actual = nu!(pipeline(
|
||||
"
|
||||
1..10 | filter { |it|
|
||||
if $it mod 2 == 0 {
|
||||
return true
|
||||
};
|
||||
return false;
|
||||
} | to nuon --raw
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "[2, 4, 6, 8, 10]");
|
||||
assert!(actual.err.is_empty());
|
||||
}
|
@ -30,6 +30,7 @@ mod every;
|
||||
mod exec;
|
||||
mod export_def;
|
||||
mod fill;
|
||||
mod filter;
|
||||
mod find;
|
||||
mod first;
|
||||
mod flatten;
|
||||
|
Reference in New Issue
Block a user