extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-10 08:40:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add ShellWarning (#16147)

Browse Source 
# Description
Adds a proper `ShellWarning` enum which has the same functionality as
`ParseWarning`.

Also moves the deprecation from #15806 into `ShellWarning::Deprecated`
with `ReportMode::FirstUse`, so that warning will only pop up once now.

# User-Facing Changes
Technically the change to the deprecation warning from #15806 is user
facing but it's really not worth listing in the changelog
This commit is contained in:
132ikl
2025-07-15 08:30:18 -04:00
committed by GitHub
parent 5569f5beff
commit 59ad605e22
14 changed files with 109 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
crates/nu-command/src/filters/default.rs
View File

@ -2,7 +2,7 @@ use std::{borrow::Cow, ops::Deref};
use nu_engine::{ClosureEval, command_prelude::*};
use nu_protocol::{
ListStream, Signals,
ListStream, ReportMode, ShellWarning, Signals,
ast::{Expr, Expression},
report_shell_warning,
};
@ -329,7 +329,7 @@ fn closure_variable_warning(
(Value::Closure { .. }, true) => {
let span_contents = String::from_utf8_lossy(engine_state.get_span_contents(span));
let carapace_suggestion = "re-run carapace init with version v1.3.3 or later\nor, change this to `{ $carapace_completer }`";
let suggestion = match span_contents {
let label = match span_contents {
Cow::Borrowed("$carapace_completer") => carapace_suggestion.to_string(),
Cow::Owned(s) if s.deref() == "$carapace_completer" => {
carapace_suggestion.to_string()
@ -339,14 +339,15 @@ fn closure_variable_warning(
report_shell_warning(
engine_state,
&ShellError::DeprecationWarning {
deprecation_type: "Behavior",
suggestion,
&ShellWarning::Deprecated {
dep_type: "Behavior".to_string(),
label,
span,
help: Some(
r"Since 0.105.0, closure literals passed to default are lazily evaluated, rather than returned as a value.
In a future release, closures passed by variable will also be lazily evaluated.",
In a future release, closures passed by variable will also be lazily evaluated.".to_string(),
),
report_mode: ReportMode::FirstUse,
},
);