From 5a1af4d661eac5b35eb02b62f54b263af2d2f7a8 Mon Sep 17 00:00:00 2001 From: Darren Schroeder <343840+fdncred@users.noreply.github.com> Date: Fri, 18 Mar 2022 12:35:28 -0500 Subject: [PATCH] fixed a couple more tests (#4870) --- crates/nu-command/tests/commands/drop.rs | 2 -- crates/nu-command/tests/commands/sort_by.rs | 4 +--- crates/nu-command/tests/commands/source.rs | 2 ++ 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/crates/nu-command/tests/commands/drop.rs b/crates/nu-command/tests/commands/drop.rs index e12fe3696b..06d2668420 100644 --- a/crates/nu-command/tests/commands/drop.rs +++ b/crates/nu-command/tests/commands/drop.rs @@ -16,8 +16,6 @@ fn columns() { assert_eq!(actual.out, "1"); } -// FIXME: jt: needs more work -#[ignore] #[test] fn more_columns_than_table_has() { let actual = nu!( diff --git a/crates/nu-command/tests/commands/sort_by.rs b/crates/nu-command/tests/commands/sort_by.rs index 719cfc2c98..5b84c002fe 100644 --- a/crates/nu-command/tests/commands/sort_by.rs +++ b/crates/nu-command/tests/commands/sort_by.rs @@ -43,8 +43,6 @@ fn by_invalid_column() { assert!(actual.err.contains("value originates here")); } -// FIXME: jt: needs more work -#[ignore] #[test] fn by_invalid_types() { let actual = nu!( @@ -53,7 +51,7 @@ fn by_invalid_types() { open cargo_sample.toml --raw | echo ["foo" 1] | sort-by - | json -r + | to json -r "# )); diff --git a/crates/nu-command/tests/commands/source.rs b/crates/nu-command/tests/commands/source.rs index 8a15a3ec14..5824d4adaa 100644 --- a/crates/nu-command/tests/commands/source.rs +++ b/crates/nu-command/tests/commands/source.rs @@ -127,7 +127,9 @@ fn sources_unicode_file_in_unicode_dir_without_spaces_2() { #[ignore] #[test] fn sources_unicode_file_in_unicode_dir_with_spaces_1() { + // this one fails try_source_foo_with_single_quotes_in("e-$ Γ¨Ρ€Ρ‚πŸš’β™žδΈ­η‰‡-j", "source_test_8"); + // this one passes try_source_foo_with_double_quotes_in("e-$ Γ¨Ρ€Ρ‚πŸš’β™žδΈ­η‰‡-j", "source_test_9"); }