From 5c1a1be02b19d9af00d8b613bbf069fb6ce3cb24 Mon Sep 17 00:00:00 2001
From: JT <547158+jntrnr@users.noreply.github.com>
Date: Tue, 15 Feb 2022 08:47:25 -0500
Subject: [PATCH] Don't error on failed external expansion (#4480)

---
 crates/nu-command/src/system/run_external.rs | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/crates/nu-command/src/system/run_external.rs b/crates/nu-command/src/system/run_external.rs
index 4731789c42..c5c7b68149 100644
--- a/crates/nu-command/src/system/run_external.rs
+++ b/crates/nu-command/src/system/run_external.rs
@@ -358,14 +358,10 @@ impl ExternalCommand {
                 if let Ok((prefix, matches)) = nu_engine::glob_from(&arg, &cwd, self.name.span) {
                     let matches: Vec<_> = matches.collect();
 
-                    // Following shells like bash, if we can't expand a glob pattern, we don't assume an empty arg
-                    // Instead, we throw an error. This helps prevent issues with things like `ls unknowndir/*` accidentally
-                    // listening the current directory.
+                    // FIXME: do we want to special-case this further? We might accidentally expand when they don't
+                    // intend to
                     if matches.is_empty() {
-                        return Err(ShellError::FileNotFoundCustom(
-                            "pattern not found".to_string(),
-                            arg.span,
-                        ));
+                        process.arg(&arg.item);
                     }
                     for m in matches {
                         if let Ok(arg) = m {