extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-06-30 22:50:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix warnings and old names (#8457)

Browse Source 
# Description

This fixes up some clippy warnings and removes some old names/info from
our unit tests

# User-Facing Changes

Internal changes only

# Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass

> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```

# After Submitting

If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
This commit is contained in:
JT
2023-03-15 18:54:55 +13:00
committed by GitHub
parent 57ce6a7c66
commit 61455b457d
41 changed files with 142 additions and 158 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
crates/nu-command/src/formats/from/xml.rs
View File

@ -395,7 +395,7 @@ mod tests {
fn parses_empty_element() -> Result<(), roxmltree::Error> {
let source = "<nu></nu>";
assert_eq!(parse(source)?, content_tag("nu", indexmap! {}, &vec![]));
assert_eq!(parse(source)?, content_tag("nu", indexmap! {}, &[]));
Ok(())
}
@ -409,7 +409,7 @@ mod tests {
content_tag(
"nu",
indexmap! {},
&vec![content_string("La era de los tres caballeros")]
&[content_string("La era de los tres caballeros")]
)
);
@ -421,7 +421,7 @@ mod tests {
let source = "\
<nu>
<dev>Andrés</dev>
<dev>Jonathan</dev>
<dev>JT</dev>
<dev>Yehuda</dev>
</nu>";
@ -431,9 +431,9 @@ mod tests {
"nu",
indexmap! {},
&vec![
content_tag("dev", indexmap! {}, &vec![content_string("Andrés")]),
content_tag("dev", indexmap! {}, &vec![content_string("Jonathan")]),
content_tag("dev", indexmap! {}, &vec![content_string("Yehuda")])
content_tag("dev", indexmap! {}, &[content_string("Andrés")]),
content_tag("dev", indexmap! {}, &[content_string("JT")]),
content_tag("dev", indexmap! {}, &[content_string("Yehuda")])
]
)
);
@ -449,7 +449,7 @@ mod tests {
assert_eq!(
parse(source)?,
content_tag("nu", indexmap! {"version" => "2.0"}, &vec![])
content_tag("nu", indexmap! {"version" => "2.0"}, &[])
);
Ok(())
@ -467,10 +467,10 @@ mod tests {
content_tag(
"nu",
indexmap! {"version" => "2.0"},
&vec![content_tag(
&[content_tag(
"version",
indexmap! {},
&vec![content_string("2.0")]
&[content_string("2.0")]
)]
)
);
@ -486,7 +486,7 @@ mod tests {
assert_eq!(
parse(source)?,
content_tag("nu", indexmap! {"version" => "2.0", "age" => "25"}, &vec![])
content_tag("nu", indexmap! {"version" => "2.0", "age" => "25"}, &[])
);
Ok(())