extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-06-30 14:40:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

Make which-support feature non-optional (#13125)

Browse Source 
# Description
Removes the `which-support` cargo feature and makes all of its
feature-gated code enabled by default in all builds. I'm not sure why
this one command is gated behind a feature. It seems to be a relic of
older code where we had features for what seems like every command.
This commit is contained in:
Ian Manske
2024-06-13 01:04:12 +00:00
committed by GitHub
parent bdbb096526
commit 634361b2d1
12 changed files with 1 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/shell/pipeline/commands/external.rs
View File

@ -3,7 +3,6 @@ use nu_test_support::nu;
use nu_test_support::playground::Playground;
use pretty_assertions::assert_eq;
#[cfg(feature = "which-support")]
#[test]
fn shows_error_for_command_not_found() {
let actual = nu!("ferris_is_not_here.exe");
@ -11,7 +10,6 @@ fn shows_error_for_command_not_found() {
assert!(!actual.err.is_empty());
}
#[cfg(feature = "which-support")]
#[test]
fn shows_error_for_command_not_found_in_pipeline() {
let actual = nu!("ferris_is_not_here.exe | echo done");
@ -20,7 +18,6 @@ fn shows_error_for_command_not_found_in_pipeline() {
}
#[ignore] // jt: we can't test this using the -c workaround currently
#[cfg(feature = "which-support")]
#[test]
fn automatically_change_directory() {
use nu_test_support::playground::Playground;

1
tests/shell/pipeline/commands/internal.rs
View File

@ -550,7 +550,6 @@ fn dynamic_closure_rest_args() {
assert_eq!(actual.out, "1, 2, 3");
}
#[cfg(feature = "which-support")]
#[test]
fn argument_subexpression_reports_errors() {
let actual = nu!("echo (ferris_is_not_here.exe)");