extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-16 11:47:53 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fixed mv not throwing error when the source path was invalid (#1351)

Browse Source 
* Fixed mv not throwing error when the source path was invalid

* Fixed failing test

* Fixed another lint error

* Fix $PATH conflicts in .gitpod.Dockerfile (#1349)

- Use the correct user for gitpod Dockerfile.
- Remove unneeded packages (curl, rustc) from gitpod Dockerfile.

* Added test to check for the error

* Fixed linting error

* Fixed mv not moving files on Windows. (#1342)

Move files correctly in windows.

* Fixed mv not throwing error when the source path was invalid

* Fixed failing test

* Fixed another lint error

* Added test to check for the error

* Fixed linting error

* Changed error message

* Typo and fixed test

Co-authored-by: Sean Hellum <seanhellum45@gmail.com>
This commit is contained in:
George Tsomlektsis
2020-02-07 19:40:48 +02:00
committed by GitHub
parent ed86b1fbe8
commit 643b532537
2 changed files with 28 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/shell/filesystem_shell.rs
View File

@ -546,6 +546,13 @@ impl Shell for FilesystemShell {
}
};
if sources.is_empty() {
return Err(ShellError::labeled_error(
"Invalid File or Pattern.",
"Invalid File or Pattern",
src.tag,
));
}
let destination_file_name = {
match destination.file_name() {
Some(name) => PathBuf::from(name),
@ -559,6 +566,14 @@ impl Shell for FilesystemShell {
}
};
if sources.is_empty() {
return Err(ShellError::labeled_error(
"Move aborted. Not a valid destination",
"not a valid destination",
src.tag,
));
}
if sources.len() == 1 {
if let Ok(entry) = &sources[0] {
let entry_file_name = match entry.file_name() {