extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2024-11-22 08:23:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix missing local socket feature (#12698)

Browse Source 
# Description

So sorry to do this during the pre-release freeze, but my plugin crate
split PR broke local socket mode, because `nu-plugin-protocol` didn't
have the compile feature to advertise the `LocalSocket` protocol
feature.

This is a very simple, configuration-only bugfix that I think really
needs to be merged before the release, or else local socket mode won't
work at all.

# Tests + Formatting

There's an oversight in my testing that caused this to not be caught:
the engine really did have the feature, but it just wasn't advertising
it, so for `stress_internals` it was still able to use it successfully.
Post-release I'll try to make sure this is properly handled somehow.
This commit is contained in:
Devyn Cairns 2024-04-29 00:02:56 -07:00 committed by GitHub
parent 59ee96c70d
commit 648486400c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/nu-plugin-core/Cargo.toml
View File

@ -12,7 +12,7 @@ bench = false
[dependencies] [dependencies]
nu-protocol = { path = "../nu-protocol", version = "0.92.3" } nu-protocol = { path = "../nu-protocol", version = "0.92.3" }
nu-plugin-protocol = { path = "../nu-plugin-protocol", version = "0.92.3" } nu-plugin-protocol = { path = "../nu-plugin-protocol", version = "0.92.3", default-features = false }
rmp-serde = { workspace = true } rmp-serde = { workspace = true }
serde = { workspace = true } serde = { workspace = true }
@ -22,7 +22,7 @@ interprocess = { workspace = true, optional = true }
[features] [features]
default = ["local-socket"] default = ["local-socket"]
local-socket = ["interprocess"] local-socket = ["interprocess", "nu-plugin-protocol/local-socket"]
[target.'cfg(target_os = "windows")'.dependencies] [target.'cfg(target_os = "windows")'.dependencies]
windows = { workspace = true } windows = { workspace = true }

4
crates/nu-plugin-protocol/Cargo.toml
View File

@ -18,3 +18,7 @@ bincode = "1.3"
serde = { workspace = true, features = ["derive"] } serde = { workspace = true, features = ["derive"] }
semver = "1.0" semver = "1.0"
typetag = "0.2" typetag = "0.2"
[features]
default = ["local-socket"]
local-socket = []