From 65e5abaa3e48126ff730c9a59e5f6f55777a85bd Mon Sep 17 00:00:00 2001
From: Wind <WindSoilder@outlook.com>
Date: Thu, 29 Feb 2024 20:29:56 +0800
Subject: [PATCH] deprecate str escape-glob command (#12018)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

# Description
After some iteration on globbing rules, I don't think `str escape-glob`
is needed

# User-Facing Changes
```nushell
❯ let f = "[ab]*.nu"
❯ $f | str escape-glob
Error:   × str escape-glob is deprecated
   ╭─[entry #1:1:6]
 1 │ $f | str escape-glob
   ·      ───────┬───────
   ·             ╰── if you are trying to escape a variable, you don't need to do it now
   ╰────
  help: Remove `str escape-glob` call

[[]ab[]][*].nu
```

# Tests + Formatting
NaN

# After Submitting
NaN
---
 crates/nu-command/src/strings/str_/escape_glob.rs | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/crates/nu-command/src/strings/str_/escape_glob.rs b/crates/nu-command/src/strings/str_/escape_glob.rs
index b2740bcd20..cf6fc8a3c5 100644
--- a/crates/nu-command/src/strings/str_/escape_glob.rs
+++ b/crates/nu-command/src/strings/str_/escape_glob.rs
@@ -59,6 +59,16 @@ impl Command for SubCommand {
         call: &Call,
         input: PipelineData,
     ) -> Result<PipelineData, ShellError> {
+        nu_protocol::report_error_new(
+            engine_state,
+            &ShellError::GenericError {
+                error: "str escape-glob is deprecated".into(),
+                msg: "if you are trying to escape a variable, you don't need to do it now".into(),
+                span: Some(call.head),
+                help: Some("Remove `str escape-glob` call".into()),
+                inner: vec![],
+            },
+        );
         let cell_paths: Vec<CellPath> = call.rest(engine_state, stack, 0)?;
         let cell_paths = (!cell_paths.is_empty()).then_some(cell_paths);
         let args = Arguments { cell_paths };