mirror of
https://github.com/nushell/nushell.git
synced 2025-07-01 07:00:37 +02:00
Speed up tight loop benchmarks (#8609)
# Description This does a few speedups for tight loops: * Caches the DeclId for `table` so we don't look it up. This means users can't easily replace the default one, we might want to talk about this tradeoff. The lookup for finding `table` in a tight loop is currently pretty heavy. Might be another way to speed this up. * `table` no longer pre-calculates the width. Instead, it only calculates the width when printing a table or record. * Use more efficient way of collecting the block of each loop * When printing output, only get the config when needed Combined, this drops the runtime from a million loop tight iteration from 1sec 8ms to 236ms. # User-Facing Changes _(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)_ # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
This commit is contained in:
@ -462,5 +462,9 @@ pub fn create_default_context() -> EngineState {
|
||||
eprintln!("Error creating default context: {err:?}");
|
||||
}
|
||||
|
||||
// Cache the table decl id so we don't have to look it up later
|
||||
let table_decl_id = engine_state.find_decl("table".as_bytes(), &[]);
|
||||
engine_state.table_decl_id = table_decl_id;
|
||||
|
||||
engine_state
|
||||
}
|
||||
|
@ -110,7 +110,6 @@ impl Command for Table {
|
||||
let list: bool = call.has_flag("list");
|
||||
|
||||
let width_param: Option<i64> = call.get_flag(engine_state, stack, "width")?;
|
||||
let term_width = get_width_param(width_param);
|
||||
|
||||
let expand: bool = call.has_flag("expand");
|
||||
let expand_limit: Option<usize> = call.get_flag(engine_state, stack, "expand-deep")?;
|
||||
@ -152,7 +151,7 @@ impl Command for Table {
|
||||
input,
|
||||
row_offset,
|
||||
table_view,
|
||||
term_width,
|
||||
width_param,
|
||||
)
|
||||
}
|
||||
|
||||
@ -232,7 +231,7 @@ fn handle_table_command(
|
||||
input: PipelineData,
|
||||
row_offset: usize,
|
||||
table_view: TableView,
|
||||
term_width: usize,
|
||||
term_width: Option<i64>,
|
||||
) -> Result<PipelineData, ShellError> {
|
||||
let ctrlc = engine_state.ctrlc.clone();
|
||||
let config = engine_state.get_config();
|
||||
@ -278,18 +277,22 @@ fn handle_table_command(
|
||||
ctrlc,
|
||||
metadata,
|
||||
),
|
||||
PipelineData::Value(Value::Record { cols, vals, span }, ..) => handle_record(
|
||||
cols,
|
||||
vals,
|
||||
span,
|
||||
engine_state,
|
||||
stack,
|
||||
call,
|
||||
table_view,
|
||||
term_width,
|
||||
ctrlc,
|
||||
config,
|
||||
),
|
||||
PipelineData::Value(Value::Record { cols, vals, span }, ..) => {
|
||||
let term_width = get_width_param(term_width);
|
||||
|
||||
handle_record(
|
||||
cols,
|
||||
vals,
|
||||
span,
|
||||
engine_state,
|
||||
stack,
|
||||
call,
|
||||
table_view,
|
||||
term_width,
|
||||
ctrlc,
|
||||
config,
|
||||
)
|
||||
}
|
||||
PipelineData::Value(Value::LazyRecord { val, .. }, ..) => {
|
||||
let collected = val.collect()?.into_pipeline_data();
|
||||
handle_table_command(
|
||||
|
Reference in New Issue
Block a user