mirror of
https://github.com/nushell/nushell.git
synced 2025-06-30 22:50:14 +02:00
Move Value to helpers, separate span call (#10121)
# Description As part of the refactor to split spans off of Value, this moves to using helper functions to create values, and using `.span()` instead of matching span out of Value directly. Hoping to get a few more helping hands to finish this, as there are a lot of commands to update :) # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. --> --------- Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com> Co-authored-by: WindSoilder <windsoilder@outlook.com>
This commit is contained in:
@ -4,21 +4,12 @@ use nu_protocol::{IntoPipelineData, Span, Value};
|
||||
fn test_convert_pipeline_data_to_value() {
|
||||
// Setup PipelineData
|
||||
let value_val = 10;
|
||||
let value = Value::Int {
|
||||
val: value_val,
|
||||
span: Span::new(1, 3),
|
||||
};
|
||||
let value = Value::int(value_val, Span::new(1, 3));
|
||||
let pipeline_data = value.into_pipeline_data();
|
||||
|
||||
// Test that conversion into Value is correct
|
||||
let new_span = Span::new(5, 6);
|
||||
let converted_value = pipeline_data.into_value(new_span);
|
||||
|
||||
assert_eq!(
|
||||
converted_value,
|
||||
Value::Int {
|
||||
val: value_val,
|
||||
span: new_span
|
||||
}
|
||||
);
|
||||
assert_eq!(converted_value, Value::int(value_val, new_span));
|
||||
}
|
||||
|
@ -9,9 +9,7 @@ fn test_comparison_nothing() {
|
||||
Value::test_float(1.0),
|
||||
];
|
||||
|
||||
let nothing = Value::Nothing {
|
||||
span: Span::test_data(),
|
||||
};
|
||||
let nothing = Value::nothing(Span::test_data());
|
||||
|
||||
for value in values {
|
||||
assert!(matches!(
|
||||
|
Reference in New Issue
Block a user