extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-08-09 05:14:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

Disallow clippy::used_underscore_binding lint (#15988)

Browse Source
This commit is contained in:
Stefan Holderbach
2025-06-18 10:19:57 +02:00
committed by GitHub
parent 29b3512494
commit 70aa7ad993
4 changed files with 37 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
crates/nu-command/src/conversions/into/binary.rs
View File

@ -142,7 +142,7 @@ fn into_binary(
}
}
fn action(input: &Value, _args: &Arguments, span: Span) -> Value {
fn action(input: &Value, args: &Arguments, span: Span) -> Value {
let value = match input {
Value::Binary { .. } => input.clone(),
Value::Int { val, .. } => Value::binary(val.to_ne_bytes().to_vec(), span),
@ -168,7 +168,7 @@ fn action(input: &Value, _args: &Arguments, span: Span) -> Value {
),
};
if _args.compact {
if args.compact {
let val_span = value.span();
if let Value::Binary { val, .. } = value {
let val = if cfg!(target_endian = "little") {

59
crates/nu-command/tests/commands/move_/umv.rs
View File

@ -422,29 +422,31 @@ fn mv_change_case_of_directory() {
let original_dir = String::from("somedir");
let new_dir = String::from("SomeDir");
let _actual = nu!(
#[allow(unused)]
let actual = nu!(
cwd: dirs.test(),
format!("mv {original_dir} {new_dir}")
);
// Doing this instead of `Path::exists()` because we need to check file existence in
// a case-sensitive way. `Path::exists()` is understandably case-insensitive on NTFS
let _files_in_test_directory: Vec<String> = std::fs::read_dir(dirs.test())
.unwrap()
.map(|de| de.unwrap().file_name().to_string_lossy().into_owned())
.collect();
#[cfg(any(target_os = "linux", target_os = "freebsd"))]
assert!(
!_files_in_test_directory.contains(&original_dir)
&& _files_in_test_directory.contains(&new_dir)
);
{
// Doing this instead of `Path::exists()` because we need to check file existence in
// a case-sensitive way. `Path::exists()` is understandably case-insensitive on NTFS
let files_in_test_directory: Vec<String> = std::fs::read_dir(dirs.test())
.unwrap()
.map(|de| de.unwrap().file_name().to_string_lossy().into_owned())
.collect();
#[cfg(any(target_os = "linux", target_os = "freebsd"))]
assert!(files_exist_at(&["somefile.txt"], dirs.test().join(new_dir)));
assert!(
!files_in_test_directory.contains(&original_dir)
&& files_in_test_directory.contains(&new_dir)
);
assert!(files_exist_at(&["somefile.txt"], dirs.test().join(new_dir)));
}
#[cfg(not(any(target_os = "linux", target_os = "freebsd")))]
_actual.err.contains("to a subdirectory of itself");
actual.err.contains("to a subdirectory of itself");
})
}
@ -458,24 +460,27 @@ fn mv_change_case_of_file() {
let original_file_name = String::from("somefile.txt");
let new_file_name = String::from("SomeFile.txt");
let _actual = nu!(
#[allow(unused)]
let actual = nu!(
cwd: dirs.test(),
format!("mv {original_file_name} -f {new_file_name}")
);
// Doing this instead of `Path::exists()` because we need to check file existence in
// a case-sensitive way. `Path::exists()` is understandably case-insensitive on NTFS
let _files_in_test_directory: Vec<String> = std::fs::read_dir(dirs.test())
.unwrap()
.map(|de| de.unwrap().file_name().to_string_lossy().into_owned())
.collect();
#[cfg(any(target_os = "linux", target_os = "freebsd"))]
assert!(
!_files_in_test_directory.contains(&original_file_name)
&& _files_in_test_directory.contains(&new_file_name)
);
{
// Doing this instead of `Path::exists()` because we need to check file existence in
// a case-sensitive way. `Path::exists()` is understandably case-insensitive on NTFS
let files_in_test_directory: Vec<String> = std::fs::read_dir(dirs.test())
.unwrap()
.map(|de| de.unwrap().file_name().to_string_lossy().into_owned())
.collect();
assert!(
!files_in_test_directory.contains(&original_file_name)
&& files_in_test_directory.contains(&new_file_name)
);
}
#[cfg(not(any(target_os = "linux", target_os = "freebsd")))]
_actual.err.contains("are the same file");
actual.err.contains("are the same file");
})
}