mirror of
https://github.com/nushell/nushell.git
synced 2025-08-16 01:48:16 +02:00
rename the types with spaces in them to use -
(#9929)
# Description before this PR, ```nushell > $.a.b | describe cell path ``` which feels inconsistent with the `cell-path` type annotation, like in ```nushell > def foo [x: cell-path] { $x | describe }; foo $.a.b cell path ``` this PR changes the name of the "cell path" type from `cell path` to `cell-path` # User-Facing Changes `cell path` is now `cell-path` in the output of `describe`. this might be a breaking change in some scripts. same goes with - `list stream` -> `list-stream` - `match pattern` -> `match-pattern` # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - ⚫ `toolkit test` - ⚫ `toolkit test stdlib` this PR adds a new `cell_path_type` test to make sure it stays equal to `cell-path` in the future. # After Submitting --------- Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>
This commit is contained in:
@ -504,7 +504,7 @@ pub fn hover(engine_state: &mut EngineState, file_path: &String, location: &Valu
|
||||
FlatShape::MatchPattern => println!(
|
||||
"{}",
|
||||
json!({
|
||||
"hover": "match pattern",
|
||||
"hover": "match-pattern",
|
||||
"span": {
|
||||
"start": span.start - offset,
|
||||
"end": span.end - offset
|
||||
|
@ -149,3 +149,8 @@ fn deeply_nested_cell_path_short_circuits() -> TestResult {
|
||||
"null",
|
||||
)
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn cell_path_type() -> TestResult {
|
||||
run_test("$.a.b | describe", "cell-path")
|
||||
}
|
||||
|
Reference in New Issue
Block a user