mirror of
https://github.com/nushell/nushell.git
synced 2025-08-09 03:15:00 +02:00
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> This PR is related to **Tests: clean up unnecessary use of cwd, pipeline(), etc. [#8670](https://github.com/nushell/nushell/issues/8670)** - Removed the `r#"..."#` raw string literal syntax, which is unnecessary when there are no special characters that need quoting from the tests that use the `nu!` macro. - `cwd:` and `pipeline()` has not changed # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
This commit is contained in:
Vikrant A P
GitHub
@ -13,10 +13,10 @@ fn lists_regular_files() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
ls
|
||||
| length
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "3");
|
||||
@ -35,10 +35,10 @@ fn lists_regular_files_using_asterisk_wildcard() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
ls *.txt
|
||||
| length
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "3");
|
||||
@ -57,10 +57,10 @@ fn lists_regular_files_using_question_mark_wildcard() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
ls *.??.txt
|
||||
| length
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "3");
|
||||
@ -82,11 +82,11 @@ fn lists_all_files_in_directories_from_stream() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
echo dir_a dir_b
|
||||
| each { |it| ls $it }
|
||||
| flatten | length
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "4");
|
||||
@ -100,10 +100,10 @@ fn does_not_fail_if_glob_matches_empty_directory() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
ls dir_a
|
||||
| length
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "0");
|
||||
@ -138,9 +138,9 @@ fn list_files_from_two_parents_up_using_multiple_dots() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test().join("foo/bar"),
|
||||
r#"
|
||||
"
|
||||
ls ... | length
|
||||
"#
|
||||
"
|
||||
);
|
||||
|
||||
assert_eq!(actual.out, "5");
|
||||
@ -160,10 +160,10 @@ fn lists_hidden_file_when_explicitly_specified() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
ls .testdotfile
|
||||
| length
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "1");
|
||||
@ -194,10 +194,10 @@ fn lists_all_hidden_files_when_glob_contains_dot() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
ls **/.*
|
||||
| length
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "3");
|
||||
@ -231,10 +231,10 @@ fn lists_all_hidden_files_when_glob_does_not_contain_dot() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
ls **/*
|
||||
| length
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "5");
|
||||
@ -255,10 +255,10 @@ fn glob_with_hidden_directory() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
ls **/*
|
||||
| length
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "");
|
||||
@ -267,10 +267,10 @@ fn glob_with_hidden_directory() {
|
||||
// will list files if provide `-a` flag.
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
ls -a **/*
|
||||
| length
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "4");
|
||||
@ -287,16 +287,16 @@ fn fails_with_ls_to_dir_without_permission() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
chmod 000 dir_a; ls dir_a
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
let check_not_root = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
id -u
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(
|
||||
@ -321,10 +321,10 @@ fn lists_files_including_starting_with_dot() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
ls -a
|
||||
| length
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "5");
|
||||
@ -426,12 +426,12 @@ fn lists_with_directory_flag_without_argument() {
|
||||
// Test if there are some files in the current directory
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
cd dir_files;
|
||||
ls --directory
|
||||
| get name
|
||||
| to text
|
||||
"#
|
||||
"
|
||||
));
|
||||
let expected = ".";
|
||||
assert_eq!(
|
||||
@ -441,12 +441,12 @@ fn lists_with_directory_flag_without_argument() {
|
||||
// Test if there is no file in the current directory
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
cd dir_empty;
|
||||
ls -D
|
||||
| get name
|
||||
| to text
|
||||
"#
|
||||
"
|
||||
));
|
||||
let expected = ".";
|
||||
assert_eq!(
|
||||
@ -497,7 +497,7 @@ fn can_list_system_folder() {
|
||||
|
||||
let ls_with_filter = nu!(
|
||||
cwd: "C:\\Windows\\System32", pipeline(
|
||||
r#"ls | where size > 10mb"#
|
||||
"ls | where size > 10mb"
|
||||
));
|
||||
assert_eq!(ls_with_filter.err, "");
|
||||
}
|
||||
@ -547,9 +547,9 @@ fn list_ignores_ansi() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
ls | find .txt | each {|| ls $in.name }
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual.err.is_empty());
|
||||
|
||||
Reference in New Issue
Block a user