mirror of
https://github.com/nushell/nushell.git
synced 2025-08-09 01:24:58 +02:00
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> This PR is related to **Tests: clean up unnecessary use of cwd, pipeline(), etc. [#8670](https://github.com/nushell/nushell/issues/8670)** - Removed the `r#"..."#` raw string literal syntax, which is unnecessary when there are no special characters that need quoting from the tests that use the `nu!` macro. - `cwd:` and `pipeline()` has not changed # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
This commit is contained in:
Vikrant A P
GitHub
@ -18,9 +18,9 @@ fn parse_script_success() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
nu-check script.nu
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual.err.is_empty());
|
||||
@ -43,9 +43,9 @@ fn parse_script_with_wrong_type() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
nu-check -d --as-module script.nu
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual.err.contains("Failed to parse content"));
|
||||
@ -67,9 +67,9 @@ fn parse_script_failure() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
nu-check -d script.nu
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual.err.contains("Unexpected end of code"));
|
||||
@ -96,9 +96,9 @@ fn parse_module_success() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
nu-check --as-module foo.nu
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual.err.is_empty());
|
||||
@ -125,9 +125,9 @@ fn parse_module_with_wrong_type() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
nu-check -d foo.nu
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual.err.contains("Failed to parse content"));
|
||||
@ -153,9 +153,9 @@ fn parse_module_failure() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
nu-check -d --as-module foo.nu
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual.err.contains("Unexpected end of code"));
|
||||
@ -167,9 +167,9 @@ fn file_not_exist() {
|
||||
Playground::setup("nu_check_test_7", |dirs, _sandbox| {
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
nu-check --as-module foo.nu
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual.err.contains("file not found"));
|
||||
@ -196,9 +196,9 @@ fn parse_unsupported_file() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
nu-check --as-module foo.txt
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual
|
||||
@ -211,9 +211,9 @@ fn parse_dir_failure() {
|
||||
Playground::setup("nu_check_test_9", |dirs, _sandbox| {
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
nu-check --as-module ~
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual
|
||||
@ -236,9 +236,9 @@ fn parse_module_success_2() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
nu-check --as-module foo.nu
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual.err.is_empty());
|
||||
@ -261,9 +261,9 @@ fn parse_script_success_with_raw_stream() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
open script.nu | nu-check
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual.err.is_empty());
|
||||
@ -290,9 +290,9 @@ fn parse_module_success_with_raw_stream() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
open foo.nu | nu-check --as-module
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual.err.is_empty());
|
||||
@ -348,9 +348,9 @@ fn parse_module_success_with_internal_stream() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
open foo.nu | lines | nu-check --as-module
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual.err.is_empty());
|
||||
@ -397,9 +397,9 @@ fn parse_script_success_with_complex_internal_stream() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
open grep.nu | lines | nu-check
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual.err.is_empty());
|
||||
@ -446,9 +446,9 @@ fn parse_script_failure_with_complex_internal_stream() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
open grep.nu | lines | nu-check
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "false".to_string());
|
||||
@ -495,9 +495,9 @@ fn parse_script_success_with_complex_external_stream() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
open grep.nu | nu-check
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual.err.is_empty());
|
||||
@ -544,9 +544,9 @@ fn parse_module_success_with_complex_external_stream() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
open grep.nu | nu-check -d --as-module
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual.err.is_empty());
|
||||
@ -593,9 +593,9 @@ fn parse_with_flag_all_success_for_complex_external_stream() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
open grep.nu | nu-check -ad
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual.err.is_empty());
|
||||
@ -642,9 +642,9 @@ fn parse_with_flag_all_failure_for_complex_external_stream() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
open grep.nu | nu-check -ad
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual.err.contains("syntax error"));
|
||||
@ -691,9 +691,9 @@ fn parse_with_flag_all_failure_for_complex_list_stream() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
open grep.nu | lines | nu-check -ad
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual.err.contains("syntax error"));
|
||||
@ -716,9 +716,9 @@ fn parse_failure_due_conflicted_flags() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
nu-check -a --as-module script.nu
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert!(actual
|
||||
@ -755,9 +755,9 @@ fn parse_script_with_nested_scripts_success() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
nu-check lol/lol.nu
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "true");
|
||||
@ -784,10 +784,10 @@ fn nu_check_respects_file_pwd() {
|
||||
|
||||
let actual = nu!(
|
||||
cwd: dirs.test(), pipeline(
|
||||
r#"
|
||||
"
|
||||
source-env lol/lol.nu;
|
||||
$env.RETURN
|
||||
"#
|
||||
"
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "true");
|
||||
|
||||
Reference in New Issue
Block a user