mirror of
https://github.com/nushell/nushell.git
synced 2024-11-22 16:33:37 +01:00
Allow auto-cd on trailing slash (#10585)
# Description This allows auto-cd (cd'ing by just typing the directory name with `cd`) to work if there's a trailing slash in the path. # User-Facing Changes This should be an improvement over previous behaviour. I don't think this clashes with any existing assumptions. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
This commit is contained in:
parent
eb6870cab5
commit
783f2a9342
@ -820,16 +820,29 @@ fn looks_like_path(orig: &str) -> bool {
|
|||||||
|| orig.starts_with('~')
|
|| orig.starts_with('~')
|
||||||
|| orig.starts_with('/')
|
|| orig.starts_with('/')
|
||||||
|| orig.starts_with('\\')
|
|| orig.starts_with('\\')
|
||||||
|
|| orig.ends_with(std::path::MAIN_SEPARATOR)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[cfg(windows)]
|
||||||
#[test]
|
#[test]
|
||||||
fn looks_like_path_windows_drive_path_works() {
|
fn looks_like_path_windows_drive_path_works() {
|
||||||
let on_windows = cfg!(windows);
|
assert!(looks_like_path("C:"));
|
||||||
assert_eq!(looks_like_path("C:"), on_windows);
|
assert!(looks_like_path("D:\\"));
|
||||||
assert_eq!(looks_like_path("D:\\"), on_windows);
|
assert!(looks_like_path("E:/"));
|
||||||
assert_eq!(looks_like_path("E:/"), on_windows);
|
assert!(looks_like_path("F:\\some_dir"));
|
||||||
assert_eq!(looks_like_path("F:\\some_dir"), on_windows);
|
assert!(looks_like_path("G:/some_dir"));
|
||||||
assert_eq!(looks_like_path("G:/some_dir"), on_windows);
|
}
|
||||||
|
|
||||||
|
#[cfg(windows)]
|
||||||
|
#[test]
|
||||||
|
fn trailing_slash_looks_like_path() {
|
||||||
|
assert!(looks_like_path("foo\\"))
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(not(windows))]
|
||||||
|
#[test]
|
||||||
|
fn trailing_slash_looks_like_path() {
|
||||||
|
assert!(looks_like_path("foo/"))
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
|
Loading…
Reference in New Issue
Block a user