From 7972aea530fdb0815039a6228846447d20e87700 Mon Sep 17 00:00:00 2001 From: Jack Wright <56345+ayax79@users.noreply.github.com> Date: Fri, 13 Jun 2025 12:35:26 -0700 Subject: [PATCH] Make polars last consistent with polars first (#15963) # Description `polars last` will only return one row by default making it consistent with `polars first` # User-Facing Changes - `polars last` will only return one row by default making it consistent with `polars first` Co-authored-by: Jack Wright --- crates/nu_plugin_polars/src/dataframe/command/data/last.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/crates/nu_plugin_polars/src/dataframe/command/data/last.rs b/crates/nu_plugin_polars/src/dataframe/command/data/last.rs index 6e1f9c53b7..ea47c3eeef 100644 --- a/crates/nu_plugin_polars/src/dataframe/command/data/last.rs +++ b/crates/nu_plugin_polars/src/dataframe/command/data/last.rs @@ -3,7 +3,7 @@ use crate::{ values::{Column, CustomValueSupport, NuLazyFrame, NuLazyGroupBy, PolarsPluginObject}, }; -use crate::values::{NuDataFrame, NuExpression, utils::DEFAULT_ROWS}; +use crate::values::{NuDataFrame, NuExpression}; use nu_plugin::{EngineInterface, EvaluatedCall, PluginCommand}; use nu_protocol::{ Category, Example, LabeledError, PipelineData, ShellError, Signature, Span, SyntaxShape, Type, @@ -11,6 +11,8 @@ use nu_protocol::{ }; use polars::df; +const DEFAULT_ROWS: usize = 1; + #[derive(Clone)] pub struct LastDF; @@ -150,7 +152,7 @@ fn command_groupby( groupby: NuLazyGroupBy, ) -> Result { let rows: Option = call.opt(0)?; - let rows = rows.unwrap_or(1); + let rows = rows.unwrap_or(DEFAULT_ROWS); let res = groupby.to_polars().tail(Some(rows)); let res: NuLazyFrame = res.into();