diff --git a/crates/nu-command/tests/commands/redirection.rs b/crates/nu-command/tests/commands/redirection.rs index 02f85a90f8..c263f27d83 100644 --- a/crates/nu-command/tests/commands/redirection.rs +++ b/crates/nu-command/tests/commands/redirection.rs @@ -473,3 +473,18 @@ fn pipe_redirection_in_let_and_mut( ); assert_eq!(actual.out, output); } + +#[rstest::rstest] +#[case("o>", "bar")] +#[case("e>", "")] +#[case("o+e>", "bar\nbaz")] // in subexpression, the stderr is go to the terminal +fn subexpression_redirection(#[case] redir: &str, #[case] stdout_file_body: &str) { + Playground::setup("file redirection with subexpression", |dirs, _| { + let actual = nu!( + cwd: dirs.test(), + format!("$env.BAR = 'bar'; $env.BAZ = 'baz'; (nu --testbin echo_env_mixed out-err BAR BAZ) {redir} result.txt") + ); + assert!(actual.status.success()); + assert!(file_contents(dirs.test().join("result.txt")).contains(stdout_file_body)); + }) +} diff --git a/crates/nu-engine/src/compile/mod.rs b/crates/nu-engine/src/compile/mod.rs index 1bdc2c6b41..f68232f9cb 100644 --- a/crates/nu-engine/src/compile/mod.rs +++ b/crates/nu-engine/src/compile/mod.rs @@ -1,5 +1,5 @@ use nu_protocol::{ - ast::{Block, Pipeline, PipelineRedirection, RedirectionSource, RedirectionTarget}, + ast::{Block, Expr, Pipeline, PipelineRedirection, RedirectionSource, RedirectionTarget}, engine::StateWorkingSet, ir::{Instruction, IrBlock, RedirectMode}, CompileError, IntoSpanned, RegId, Span, @@ -194,11 +194,25 @@ fn compile_pipeline( out_reg, )?; - // Clean up the redirection - finish_redirection(builder, redirect_modes, out_reg)?; + // only clean up the redirection if current element is not + // a subexpression. The subexpression itself already clean it. + if !is_subexpression(&element.expr.expr) { + // Clean up the redirection + finish_redirection(builder, redirect_modes, out_reg)?; + } // The next pipeline element takes input from this output in_reg = Some(out_reg); } Ok(()) } + +fn is_subexpression(expr: &Expr) -> bool { + match expr { + Expr::FullCellPath(inner) => { + matches!(&inner.head.expr, &Expr::Subexpression(..)) + } + Expr::Subexpression(..) => true, + _ => false, + } +}