From 7b88bda9a12cd86fd4c2e0efac6b1708d1c24777 Mon Sep 17 00:00:00 2001 From: Yash Thakur <45539777+ysthakur@users.noreply.github.com> Date: Fri, 16 May 2025 02:21:40 -0400 Subject: [PATCH] Use Default for making Suggestions in attribute_completions (#15764) # Description In preparation for https://github.com/nushell/reedline/pull/798, which adds a new field to `Suggestion`, this PR makes sure that `Suggestion`s are created using `..Default::default()` inside `attribute_completions.rs`. # User-Facing Changes None # Tests + Formatting None # After Submitting --- crates/nu-cli/src/completions/attribute_completions.rs | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/crates/nu-cli/src/completions/attribute_completions.rs b/crates/nu-cli/src/completions/attribute_completions.rs index 9558032fab..46ba1af0f5 100644 --- a/crates/nu-cli/src/completions/attribute_completions.rs +++ b/crates/nu-cli/src/completions/attribute_completions.rs @@ -33,13 +33,12 @@ impl Completer for AttributeCompletion { suggestion: Suggestion { value: String::from_utf8_lossy(name).into_owned(), description: desc, - style: None, - extra: None, span: reedline::Span { start: span.start - offset, end: span.end - offset, }, append_whitespace: false, + ..Default::default() }, kind: Some(SuggestionKind::Command(ty, Some(decl_id))), }); @@ -70,13 +69,12 @@ impl Completer for AttributableCompletion { suggestion: Suggestion { value: cmd.name().into(), description: Some(cmd.description().into()), - style: None, - extra: None, span: reedline::Span { start: span.start - offset, end: span.end - offset, }, append_whitespace: false, + ..Default::default() }, kind: Some(SuggestionKind::Command(cmd.command_type(), None)), });