extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2025-06-30 14:40:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Primitives now use color closures..." (#7710)

Browse Source 
This temporarily reverts commit c5639cd9fa
(PR https://github.com/nushell/nushell/pull/7650). See
[here](https://github.com/nushell/nushell/pull/7650#issuecomment-1375036213)
for details; the PR is accidentally adding ANSI escape codes to strings
piped to externals.

I think we should revert the PR because we're only 1-2 days away from a
release; reverting it will give us more time to land+test a proper fix
in the next release cycle.
This commit is contained in:
Reilly Wood
2023-01-08 21:53:52 -08:00
committed by GitHub
parent cef05d3553
commit 80463d12fb
10 changed files with 27 additions and 104 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/shell/pipeline/commands/external.rs
View File

@ -329,7 +329,7 @@ mod nu_commands {
nu -c "echo 'foo'"
"#);
assert_eq!(nu_utils::strip_ansi_string_likely(actual.out), "foo");
assert_eq!(actual.out, "foo");
}
#[test]
@ -340,7 +340,7 @@ mod nu_commands {
"#);
// cargo for non rust project's exit code is 101.
assert_eq!(nu_utils::strip_ansi_string_likely(actual.out), "101")
assert_eq!(actual.out, "101")
})
}
@ -387,7 +387,7 @@ mod nu_script {
nu script.nu
"#);
assert_eq!(nu_utils::strip_ansi_string_likely(actual.out), "done");
assert_eq!(actual.out, "done");
}
#[test]
@ -396,7 +396,7 @@ mod nu_script {
nu script_multiline.nu
"#);
assert_eq!(nu_utils::strip_ansi_string_likely(actual.out), "23");
assert_eq!(actual.out, "23");
}
}