mirror of
https://github.com/nushell/nushell.git
synced 2025-06-30 14:40:06 +02:00
Disable alias recursion (#8397)
# Description Prevents alias from aliasing itself. It allows a commonly requested pattern similar to `alias ls = ls -l`. One small issue is that the syntax highlighting is a bit off:  Fixes https://github.com/nushell/nushell/issues/8246 # User-Facing Changes Shouldn't be a breaking change. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
This commit is contained in:
@ -90,3 +90,23 @@ fn cant_alias_keyword() {
|
||||
));
|
||||
assert!(actual.err.contains("cant_alias_keyword"));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn alias_wont_recurse() {
|
||||
let actual = nu!(
|
||||
cwd: ".", pipeline(
|
||||
r#"
|
||||
module myspamsymbol {
|
||||
export def myfoosymbol [prefix: string, msg: string] {
|
||||
$prefix + $msg
|
||||
}
|
||||
};
|
||||
use myspamsymbol myfoosymbol;
|
||||
alias myfoosymbol = myfoosymbol 'hello';
|
||||
myfoosymbol ' world'
|
||||
"#
|
||||
));
|
||||
|
||||
assert_eq!(actual.out, "hello world");
|
||||
assert!(actual.err.is_empty());
|
||||
}
|
||||
|
Reference in New Issue
Block a user