Initial implementation for uutils uname (#11684)

Hi,
This PR aims at implementing the first iteration for `uname` using
`uutils`. Couple of things:
* Currently my [PR](https://github.com/uutils/coreutils/pull/5921) to
make the required changes is pending in `uutils` repo.
* I guess the number of flags has to be investigated. Still the tests
cover all of them.


<!--
if this PR closes one or more issues, you can automatically link the PR
with
them by using one of the [*linking
keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword),
e.g.
- this PR should close #xxxx
- fixes #xxxx

you can also mention related issues, PRs or discussions!
-->

# Description
<!--
Thank you for improving Nushell. Please, check our [contributing
guide](../CONTRIBUTING.md) and talk to the core team before making major
changes.

Description of your pull request goes here. **Provide examples and/or
screenshots** if your changes affect the user experience.
-->

# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->

# Tests + Formatting
Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- [X] `cargo fmt --all -- --check` to check standard code formatting
(`cargo fmt --all` applies these changes)
- [X] `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used`
to check that you're using the standard code style
- [X] `cargo test --workspace` to check that all tests pass (on Windows
make sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- [X] `cargo run -- -c "use std testing; testing run-tests --path
crates/nu-std"` to run the tests for the standard library

> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->

# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->

---------

Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>
This commit is contained in:
David Matos
2024-03-25 22:51:50 +01:00
committed by GitHub
parent 87c5f6e455
commit 838fc7e098
8 changed files with 180 additions and 26 deletions

View File

@ -91,6 +91,7 @@ uu_cp = { workspace = true }
uu_mkdir = { workspace = true }
uu_mktemp = { workspace = true }
uu_mv = { workspace = true }
uu_uname = { workspace = true }
uu_whoami = { workspace = true }
uuid = { workspace = true, features = ["v4"] }
v_htmlescape = { workspace = true }

View File

@ -122,6 +122,8 @@ pub fn add_shell_command_context(mut engine_state: EngineState) -> EngineState {
Exec,
NuCheck,
Sys,
UName,
};
// Help

View File

@ -13,6 +13,7 @@ mod ps;
mod registry_query;
mod run_external;
mod sys;
mod uname;
mod which_;
pub use complete::Complete;
@ -30,4 +31,5 @@ pub use ps::Ps;
pub use registry_query::RegistryQuery;
pub use run_external::{External, ExternalCommand};
pub use sys::Sys;
pub use uname::UName;
pub use which_::Which;

View File

@ -0,0 +1,100 @@
use nu_protocol::record;
use nu_protocol::Value;
use nu_protocol::{
ast::Call,
engine::{Command, EngineState, Stack},
Category, Example, PipelineData, ShellError, Signature, Type,
};
#[derive(Clone)]
pub struct UName;
impl Command for UName {
fn name(&self) -> &str {
"uname"
}
fn signature(&self) -> Signature {
Signature::build("uname")
.input_output_types(vec![(Type::Nothing, Type::Table(vec![]))])
.category(Category::System)
}
fn usage(&self) -> &str {
"Print certain system information."
}
fn search_terms(&self) -> Vec<&str> {
// add other terms?
vec!["system"]
}
fn run(
&self,
_engine_state: &EngineState,
_stack: &mut Stack,
call: &Call,
_input: PipelineData,
) -> Result<PipelineData, ShellError> {
let span = call.head;
// Simulate `uname -all` is called every time
let opts = uu_uname::Options {
all: true,
kernel_name: false,
nodename: false,
kernel_release: false,
kernel_version: false,
machine: false,
processor: false,
hardware_platform: false,
os: false,
};
let output = uu_uname::UNameOutput::new(&opts).map_err(|e| ShellError::GenericError {
error: format!("{}", e),
msg: format!("{}", e),
span: None,
help: None,
inner: Vec::new(),
})?;
let outputs = [
output.kernel_name,
output.nodename,
output.kernel_release,
output.kernel_version,
output.machine,
output.os,
];
let outputs = outputs
.iter()
.map(|name| {
Ok(name
.as_ref()
.ok_or("unknown")
.map_err(|_| ShellError::NotFound { span })?
.to_string())
})
.collect::<Result<Vec<String>, ShellError>>()?;
Ok(PipelineData::Value(
Value::record(
record! {
"kernel-name" => Value::string(outputs[0].clone(), span),
"nodename" => Value::string(outputs[1].clone(), span),
"kernel-release" => Value::string(outputs[2].clone(), span),
"kernel-version" => Value::string(outputs[3].clone(), span),
"machine" => Value::string(outputs[4].clone(), span),
"operating-system" => Value::string(outputs[5].clone(), span),
},
span,
),
None,
))
}
fn examples(&self) -> Vec<Example> {
vec![Example {
description: "Print all information",
example: "uname",
result: None,
}]
}
}

View File

@ -111,7 +111,9 @@ mod try_;
mod ucp;
#[cfg(unix)]
mod ulimit;
mod umkdir;
mod uname;
mod uniq;
mod uniq_by;
mod update;

View File

@ -0,0 +1,12 @@
use nu_test_support::nu;
use nu_test_support::playground::Playground;
#[test]
fn test_uname_all() {
Playground::setup("uname_test_1", |dirs, _| {
let actual = nu!(
cwd: dirs.test(),
"uname"
);
assert!(actual.status.success())
})
}