mirror of
https://github.com/nushell/nushell.git
synced 2025-08-09 19:57:44 +02:00
Remove cd w/ abbreviations (#10588)
# Description This removes the old style "cd with abbreviations" that would attempt to guess what directory you wanted to `cd` to. This would sometimes have false positives, so we left it off by default in the config. In the current main, we have much-improved path completions (https://github.com/nushell/nushell/pull/10543) so you can now do `cd a/b<tab>` and get a much better experience (because you can see the directory you're about to cd to). This removes the need for the previous abbreviation system. # User-Facing Changes This does remove the old abbreviation system. It will likely mean that old config files that have settings for abbreviations will now get errors. update: here's an example of the error you'll see:  # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
This commit is contained in:
@ -100,7 +100,6 @@ pub struct Config {
|
||||
pub shell_integration: bool,
|
||||
pub buffer_editor: Value,
|
||||
pub table_index_mode: TableIndexMode,
|
||||
pub cd_with_abbreviations: bool,
|
||||
pub case_sensitive_completions: bool,
|
||||
pub enable_external_completion: bool,
|
||||
pub trim_strategy: TrimStrategy,
|
||||
@ -128,8 +127,6 @@ impl Default for Config {
|
||||
|
||||
rm_always_trash: false,
|
||||
|
||||
cd_with_abbreviations: false,
|
||||
|
||||
table_mode: "rounded".into(),
|
||||
table_index_mode: TableIndexMode::Always,
|
||||
table_show_empty: true,
|
||||
@ -387,19 +384,14 @@ impl Value {
|
||||
for index in (0..cols.len()).rev() {
|
||||
let value = &vals[index];
|
||||
let key2 = cols[index].as_str();
|
||||
match key2 {
|
||||
"abbreviations" => {
|
||||
try_bool!(cols, vals, index, span, cd_with_abbreviations)
|
||||
}
|
||||
x => {
|
||||
invalid_key!(
|
||||
cols,
|
||||
vals,
|
||||
index,
|
||||
Some(value.span()),
|
||||
"$env.config.{key}.{x} is an unknown config setting"
|
||||
);
|
||||
}
|
||||
{
|
||||
invalid_key!(
|
||||
cols,
|
||||
vals,
|
||||
index,
|
||||
Some(value.span()),
|
||||
"$env.config.{key}.{key2} is an unknown config setting"
|
||||
);
|
||||
}
|
||||
}
|
||||
} else {
|
||||
|
Reference in New Issue
Block a user